-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix version-specific GH link in customizing_html5_shell.rst #11444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
xhocquet
wants to merge
1
commit into
godotengine:3.6
Choose a base branch
from
xhocquet:patch-1
base: 3.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Let me know if there's any interest in this type of change, and I'd be happy to put up PRs for further updates! If not, no worries 🙏🏻 |
Member
|
List of links that could be replaced ( Not all of these should necessarily be replaced, but it's worth keeping in mind. |
Author
|
@Calinou do you agree that these changes are worthwhile? If so I can go through and use my best judgement on the ones you have listed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:manual
Issues and PRs related to the Manual/Tutorials section of the documentation
bug
platform:web
topic:export
topic:platforms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link points to
main, which cost me a couple hours as I tried to figure out errors that didn't belong to Godot 3! There might be value in find + replacing similar links in the docs and pinning them to tagged versions of github files, instead of theirmainversions