Updated exit codes with clearer message. #401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megha1188
requested review from
R2wenD2,
allenhutchison,
mattKorwel and
verbanicm
MJjainam
reviewed
Nov 26, 2025
Collaborator
|
@gemini-cli /review |
|
🤖 Hi @MJjainam, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![gemini-cli[bot]](https://avatars.githubusercontent.com/in/1473539?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request introduces a valuable improvement to error handling in the action. By mapping specific exit codes from the Gemini CLI to user-friendly error messages and preserving the original exit code, it will be much easier for users to diagnose and debug failures.
🔍 General Feedback
- The use of a
casestatement is clean and effective for handling the different exit codes. - The enhanced error messages are clear and will significantly improve the user experience.
- The change to exit with the original exit code is a great enhancement for users who rely on this action in larger scripts.
megha1188
force-pushed
the
main
branch
3 times, most recently
from
0f758cc to
70d215d
Compare
MJjainam
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error handling by providing more specific error messages based on the exit code from the Gemini CLI.
Previously, the action would exit with a generic "Gemini CLI execution failed" message. This change introduces a case statement that maps common exit codes to user-friendly messages, making it easier to diagnose the root cause of a failure. The action now also exits with the original exit code from the Gemini CLI, which can be useful for scripting and automation.
For example, a failure due to an invalid API key will now produce the message: "Gemini CLI execution failed (Authentication failure. Please check your credentials (API key or Google Cloud auth))" and exit with code 41.
Related Issue #217