Skip to content

Port to WASM #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Port to WASM #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
224fc9d
Port to WASM
mjohnson9 Sep 15, 2018
b93db86
Add large read test
mjohnson9 Sep 16, 2018
14ad807
Make the conn.onMessage callback never block
mjohnson9 Sep 16, 2018
0d6cf3a
Make websocketjs.WebSocket.Send accept js.Value
mjohnson9 Sep 16, 2018
bc9bf10
Remove legacy TypedArray code from websocketjs.WebSocket.Send
mjohnson9 Sep 16, 2018
66e2b26
Refactor tests based on the module they're testing
mjohnson9 Sep 16, 2018
5fba360
Add test for large binary echo
mjohnson9 Sep 16, 2018
8097c44
Reuse buffer in echo test
mjohnson9 Sep 16, 2018
52bb973
Add check for extra data to echo test
mjohnson9 Sep 16, 2018
960b81e
Rename TestWSTimeout -> TestConnTimeout
mjohnson9 Sep 16, 2018
8501e8e
Minor cleanup of commented code; style fixes
mjohnson9 Sep 16, 2018
5ad98ea
Add logic to close the 30 second wait socket in tests after the clien…
mjohnson9 Oct 6, 2018
27a28a5
Add new fast path for websocket.conn.Read
mjohnson9 Oct 6, 2018
6fe0f86
Move to gopherwasm/js package for JavaScript interactions
mjohnson9 Oct 6, 2018
5ba46d5
Remove new websocket.conn.Read fast path; it breaks EOF logic
mjohnson9 Oct 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,9 @@ func (c *conn) Read(b []byte) (n int, err error) {
func (c *conn) Write(b []byte) (n int, err error) {
// []byte is converted to an Uint8Array by GopherJS, which fullfils the
// ArrayBufferView definition.
err = c.Send(b)
byteArray := js.TypedArrayOf(b)
defer byteArray.Release()
err = c.Send(byteArray.Value)
if err != nil {
return 0, err
}
Expand Down
2 changes: 1 addition & 1 deletion websocketjs/websocketjs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func (ws *WebSocket) RemoveEventListener(typ string, callback js.Callback) {
// js.Value fulfilling the ArrayBufferView definition.
//
// See: http://dev.w3.org/html5/websockets/#dom-websocket-send
func (ws *WebSocket) Send(data []byte) (err error) {
func (ws *WebSocket) Send(data js.Value) (err error) {
defer func() {
e := recover()
if e == nil {
Expand Down