Fixed direct call of prune_points() issue #1288
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original code self.tmp_radii is not declared in self.__init__()
In train.py when densify_and_prune() is called it declares self.tmp_radii and sets self.tmp_radii to None once densification and pruning is done.
Hence, if prune_points() in called it will throw error as attribute does not exist (or) if densify_and_prune() was called before it will throw error as we are accessing None.
To rectify this and for better practice
1. Added self.tmp_radii = None to self.__init__()
2. Added condition to check if self.temp_radii is not None before accessing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code
self.tmp_radiiis not declared inself.__init__()In train.py when
densify_and_prune()is called it declaresself.tmp_radiiand setsself.tmp_radiito None once densification and pruning is done.Hence, if
prune_points()in called it will throw error as attribute does not exist (or) ifdensify_and_prune()was called before it will throw error as we are accessing None.To rectify this and for better practice
self.tmp_radii = Nonetoself.__init__()if self.temp_radii is not Nonebefore accessing