s2a: Remove channel.awaitTermination() from S2A ChannelResource. #12424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ejona86 , would you be able to review this PR? I sent you an email with some additional context. Thank you. |
Member
|
You can and should link to bugs here, so you'd include a reference to b/388769143. |
ejona86
reviewed
Oct 17, 2025
s2a/src/main/java/io/grpc/s2a/internal/channel/S2AHandshakerServiceChannel.java
Show resolved
Hide resolved
rmehta19
changed the title
Member
|
@rmehta19, see the CI failures |
ejona86
added
the
kokoro:run
Member
|
/gcbrun |
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/388769143