Clear errno before calling strtol() #1104
Open
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two commands that were incorrectly rejecting valid integer values:
pg_autoctl set node candidate-prioritypg_autoctl set formation number-sync-standbysThe strtol() function does not reset errno to 0 on success, so checking errno without clearing it first can detect stale error values from unrelated operations.
refs #1011, #929
The current version fails with
Expected a non-negative integer value. This occured in a monitor node only (if on worker node, works fine). See also #1011 (comment)This fixe works as expected.