Skip to content

opensearch: Remove 10-minute delays from domain creation and deletion #45245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

opensearch: Remove 10-minute delays from domain creation and deletion #45245

wants to merge 3 commits into from

Conversation

@berimbolo13
Copy link

@berimbolo13 berimbolo13 commented Nov 25, 2025 •
edited
Loading

Closes #45244

Removes hardcoded delays before polling domain state during creation, update, and deletion operations. The provider will now begin polling immediately with a 10-second interval for all operations.

This significantly reduces wait times for:

  • Fast AWS provisioning scenarios
  • Local testing with LocalStack (lightweight AWS emulator)

Changes:

  • Removed tfresource.WithDelay(10*time.Minute) from waitForDomainCreation()
  • Removed tfresource.WithDelay(1*time.Minute) from waitForDomainUpdate() (for consistency)
  • Removed tfresource.WithDelay(10*time.Minute) from waitForDomainDelete()
  • Kept tfresource.WithPollInterval(10*time.Second) to prevent API rate limiting
  • Updated changelog entry in .changelog/45245.txt

Domain Creation Performance Test (LocalStack):

  • Before: 600+ seconds (10+ minutes minimum)
  • After: ~19 seconds
  • Improvement: ~30x faster

Note on Consistency:
PR #32209 reduced the update delay from 10 minutes to 1 minute. This PR goes further by removing delays entirely from all operations (create/update/delete) for consistency and maximum performance improvement.

Related:

@berimbolo13 berimbolo13 requested a review from a team as a code owner November 25, 2025 07:59
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025 •
edited
Loading

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/opensearch Issues and PRs that pertain to the opensearch service. size/XS Managed by automation to categorize the size of a PR. labels Nov 25, 2025
@berimbolo13
Use .changelog directory instead of modifying CHANGELOG.md directly
44472a4
@berimbolo13
Remove 1-minute delay from waitForDomainUpdate for consistency
99f5bd6 
For consistency with create and delete operations, remove the 1-minute
delay from update operations as well. All three operations now poll
immediately with a 10-second interval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/opensearch Issues and PRs that pertain to the opensearch service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OpenSearch domain creation has 10-minute hardcoded delay

1 participant

@berimbolo13