Skip to content

[Enhancement] aws_cloudwatch_log_group: Add deletion_protection_enabled argument #45298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewbankkit merged 9 commits into from
Dec 3, 2025
Merged

[Enhancement] aws_cloudwatch_log_group: Add deletion_protection_enabled argument #45298

ewbankkit merged 9 commits into from
Dec 3, 2025
+89 −0

Conversation

@tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented Nov 27, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR adds the deletion_protection_enabled argument/attribute to the aws_cloudwatch_log_group resource and data source.

  • When updating, the PutLogGroupDeletionProtection API is used to modify deletion_protection_enabled.
    Unlike other Put* APIs that accept a log group name, this API requires the ARN.
    To retrieve the ARN, findLogGroupByName is called.

Relations

Closes #45278

References

https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_CreateLogGroup.html#CWL-CreateLogGroup-request-deletionProtectionEnabled

Output from Acceptance Testing

Resource

$ make testacc TESTS='TestAccLogsLogGroup_[^L]' PKG=logs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_cloudwatch_log_group-add_deletion_protection_enabled 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/logs/... -v -count 1 -parallel 20 -run='TestAccLogsLogGroup_[^L]'  -timeout 360m -vet=off
2025/11/27 22:38:36 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/27 22:38:36 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLogsLogGroup_Identity_Basic
=== PAUSE TestAccLogsLogGroup_Identity_Basic
=== RUN   TestAccLogsLogGroup_Identity_RegionOverride
=== PAUSE TestAccLogsLogGroup_Identity_RegionOverride
=== RUN   TestAccLogsLogGroup_Identity_ExistingResource
=== PAUSE TestAccLogsLogGroup_Identity_ExistingResource
=== RUN   TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccLogsLogGroup_tags
=== PAUSE TestAccLogsLogGroup_tags
=== RUN   TestAccLogsLogGroup_tags_null
=== PAUSE TestAccLogsLogGroup_tags_null
=== RUN   TestAccLogsLogGroup_tags_EmptyMap
=== PAUSE TestAccLogsLogGroup_tags_EmptyMap
=== RUN   TestAccLogsLogGroup_tags_AddOnUpdate
=== PAUSE TestAccLogsLogGroup_tags_AddOnUpdate
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnCreate
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnCreate
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_providerOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_providerOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_overlapping
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_overlapping
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnCreate
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnCreate
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccLogsLogGroup_basic
=== PAUSE TestAccLogsLogGroup_basic
=== RUN   TestAccLogsLogGroup_nameGenerate
=== PAUSE TestAccLogsLogGroup_nameGenerate
=== RUN   TestAccLogsLogGroup_namePrefix
=== PAUSE TestAccLogsLogGroup_namePrefix
=== RUN   TestAccLogsLogGroup_disappears
=== PAUSE TestAccLogsLogGroup_disappears
=== RUN   TestAccLogsLogGroup_kmsKey
=== PAUSE TestAccLogsLogGroup_kmsKey
=== RUN   TestAccLogsLogGroup_logGroupClass
=== PAUSE TestAccLogsLogGroup_logGroupClass
=== RUN   TestAccLogsLogGroup_retentionPolicy
=== PAUSE TestAccLogsLogGroup_retentionPolicy
=== RUN   TestAccLogsLogGroup_multiple
=== PAUSE TestAccLogsLogGroup_multiple
=== RUN   TestAccLogsLogGroup_skipDestroy
=== PAUSE TestAccLogsLogGroup_skipDestroy
=== RUN   TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== PAUSE TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== RUN   TestAccLogsLogGroup_logGroupClassDELIVERY1
=== PAUSE TestAccLogsLogGroup_logGroupClassDELIVERY1
=== RUN   TestAccLogsLogGroup_logGroupClassDELIVERY2
=== PAUSE TestAccLogsLogGroup_logGroupClassDELIVERY2
=== RUN   TestAccLogsLogGroup_requiredTags
    group_test.go:411: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_defaultTags
    group_test.go:501: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_defaultTags (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_warning
    group_test.go:583: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_warning (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_disabled
    group_test.go:680: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_disabled (0.00s)
=== RUN   TestAccLogsLogGroup_deletionProtectionEnabled
=== PAUSE TestAccLogsLogGroup_deletionProtectionEnabled
=== CONT  TestAccLogsLogGroup_Identity_Basic
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccLogsLogGroup_tags_null
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_overlapping
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
=== CONT  TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
=== CONT  TestAccLogsLogGroup_tags
=== CONT  TestAccLogsLogGroup_kmsKey
=== CONT  TestAccLogsLogGroup_deletionProtectionEnabled
=== CONT  TestAccLogsLogGroup_logGroupClassDELIVERY2
=== CONT  TestAccLogsLogGroup_logGroupClassDELIVERY1
=== CONT  TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnCreate
--- PASS: TestAccLogsLogGroup_logGroupClassDELIVERY2 (43.80s)
=== CONT  TestAccLogsLogGroup_skipDestroy
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag (58.36s)
=== CONT  TestAccLogsLogGroup_multiple
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag (67.70s)
=== CONT  TestAccLogsLogGroup_retentionPolicy
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag (68.34s)
=== CONT  TestAccLogsLogGroup_logGroupClass
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag (68.83s)
=== CONT  TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccLogsLogGroup_skipDestroyInconsistentPlan (72.75s)
=== CONT  TestAccLogsLogGroup_disappears
--- PASS: TestAccLogsLogGroup_Identity_Basic (80.63s)
=== CONT  TestAccLogsLogGroup_namePrefix
--- PASS: TestAccLogsLogGroup_skipDestroy (41.41s)
=== CONT  TestAccLogsLogGroup_nameGenerate
--- PASS: TestAccLogsLogGroup_tags_null (85.90s)
=== CONT  TestAccLogsLogGroup_basic
--- PASS: TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange (97.73s)
=== CONT  TestAccLogsLogGroup_tags_AddOnUpdate
--- PASS: TestAccLogsLogGroup_logGroupClassDELIVERY1 (98.75s)
=== CONT  TestAccLogsLogGroup_tags_EmptyMap
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly (102.46s)
=== CONT  TestAccLogsLogGroup_Identity_ExistingResource
--- PASS: TestAccLogsLogGroup_multiple (44.40s)
=== CONT  TestAccLogsLogGroup_Identity_RegionOverride
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly (105.91s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace (110.46s)
=== CONT  TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnCreate (110.67s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccLogsLogGroup_logGroupClass (44.84s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnCreate
--- PASS: TestAccLogsLogGroup_disappears (48.06s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_providerOnly
--- PASS: TestAccLogsLogGroup_kmsKey (135.07s)
--- PASS: TestAccLogsLogGroup_namePrefix (68.53s)
--- PASS: TestAccLogsLogGroup_nameGenerate (64.01s)
--- PASS: TestAccLogsLogGroup_basic (63.38s)
--- PASS: TestAccLogsLogGroup_deletionProtectionEnabled (149.40s)
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add (169.36s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping (184.21s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_overlapping (184.36s)
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnCreate (71.34s)
--- PASS: TestAccLogsLogGroup_retentionPolicy (125.56s)
--- PASS: TestAccLogsLogGroup_Identity_RegionOverride (90.62s)
--- PASS: TestAccLogsLogGroup_tags_AddOnUpdate (100.24s)
--- PASS: TestAccLogsLogGroup_tags_EmptyMap (99.23s)
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace (96.37s)
--- PASS: TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag (133.83s)
--- PASS: TestAccLogsLogGroup_Identity_ExistingResource (103.79s)
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add (97.55s)
--- PASS: TestAccLogsLogGroup_tags (208.93s)
--- PASS: TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag (102.35s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_providerOnly (123.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/logs       248.554s

Data Source

$ make testacc TESTS='TestAccLogsLogGroupDataSource_' PKG=logs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_cloudwatch_log_group-add_deletion_protection_enabled 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/logs/... -v -count 1 -parallel 20 -run='TestAccLogsLogGroupDataSource_'  -timeout 360m -vet=off
2025/11/27 22:45:43 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/27 22:45:43 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLogsLogGroupDataSource_tags
=== PAUSE TestAccLogsLogGroupDataSource_tags
=== RUN   TestAccLogsLogGroupDataSource_tags_NullMap
=== PAUSE TestAccLogsLogGroupDataSource_tags_NullMap
=== RUN   TestAccLogsLogGroupDataSource_tags_EmptyMap
=== PAUSE TestAccLogsLogGroupDataSource_tags_EmptyMap
=== RUN   TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccLogsLogGroupDataSource_tags
=== CONT  TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping
=== CONT  TestAccLogsLogGroupDataSource_tags_EmptyMap
=== CONT  TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccLogsLogGroupDataSource_tags_NullMap
--- PASS: TestAccLogsLogGroupDataSource_tags_EmptyMap (24.42s)
--- PASS: TestAccLogsLogGroupDataSource_tags_NullMap (24.58s)
--- PASS: TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping (25.05s)
--- PASS: TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag (25.12s)
--- PASS: TestAccLogsLogGroupDataSource_tags (25.23s)
--- PASS: TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag (25.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/logs       29.584s

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/logs Issues and PRs that pertain to the logs service. size/M Managed by automation to categorize the size of a PR. labels Nov 27, 2025
@tabito-hara tabito-hara marked this pull request as ready for review November 27, 2025 14:30
@tabito-hara tabito-hara requested a review from a team as a code owner November 27, 2025 14:30
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 3, 2025
@ewbankkit ewbankkit self-assigned this Dec 3, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 3, 2025
ewbankkit
ewbankkit reviewed Dec 3, 2025
View reviewed changes
@tabito-hara
Copy link
Contributor Author

tabito-hara commented Dec 3, 2025 •
edited
Loading

Updated the branch:

  • Add Computed to deletion_protection_enabled argument.
  • Remove tests to disable this feature by removing the argument.
  • Update the documentation to clarify that once set, switching to false requires explicitly specifying this argument, since the argument is marked as Optional and Computed.

Rerun the acceptance tests

$ make testacc TESTS='TestAccLogsLogGroup_[^L]' PKG=logs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_cloudwatch_log_group-add_deletion_protection_enabled 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/logs/... -v -count 1 -parallel 20 -run='TestAccLogsLogGroup_[^L]'  -timeout 360m -vet=off
2025/12/04 01:46:00 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/04 01:46:00 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLogsLogGroup_Identity_Basic
=== PAUSE TestAccLogsLogGroup_Identity_Basic
=== RUN   TestAccLogsLogGroup_Identity_RegionOverride
=== PAUSE TestAccLogsLogGroup_Identity_RegionOverride
=== RUN   TestAccLogsLogGroup_Identity_ExistingResource
=== PAUSE TestAccLogsLogGroup_Identity_ExistingResource
=== RUN   TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccLogsLogGroup_tags
=== PAUSE TestAccLogsLogGroup_tags
=== RUN   TestAccLogsLogGroup_tags_null
=== PAUSE TestAccLogsLogGroup_tags_null
=== RUN   TestAccLogsLogGroup_tags_EmptyMap
=== PAUSE TestAccLogsLogGroup_tags_EmptyMap
=== RUN   TestAccLogsLogGroup_tags_AddOnUpdate
=== PAUSE TestAccLogsLogGroup_tags_AddOnUpdate
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnCreate
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnCreate
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_providerOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_providerOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_overlapping
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_overlapping
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnCreate
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnCreate
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccLogsLogGroup_basic
=== PAUSE TestAccLogsLogGroup_basic
=== RUN   TestAccLogsLogGroup_nameGenerate
=== PAUSE TestAccLogsLogGroup_nameGenerate
=== RUN   TestAccLogsLogGroup_namePrefix
=== PAUSE TestAccLogsLogGroup_namePrefix
=== RUN   TestAccLogsLogGroup_disappears
=== PAUSE TestAccLogsLogGroup_disappears
=== RUN   TestAccLogsLogGroup_kmsKey
=== PAUSE TestAccLogsLogGroup_kmsKey
=== RUN   TestAccLogsLogGroup_logGroupClass
=== PAUSE TestAccLogsLogGroup_logGroupClass
=== RUN   TestAccLogsLogGroup_retentionPolicy
=== PAUSE TestAccLogsLogGroup_retentionPolicy
=== RUN   TestAccLogsLogGroup_multiple
=== PAUSE TestAccLogsLogGroup_multiple
=== RUN   TestAccLogsLogGroup_skipDestroy
=== PAUSE TestAccLogsLogGroup_skipDestroy
=== RUN   TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== PAUSE TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== RUN   TestAccLogsLogGroup_logGroupClassDELIVERY1
=== PAUSE TestAccLogsLogGroup_logGroupClassDELIVERY1
=== RUN   TestAccLogsLogGroup_logGroupClassDELIVERY2
=== PAUSE TestAccLogsLogGroup_logGroupClassDELIVERY2
=== RUN   TestAccLogsLogGroup_requiredTags
    group_test.go:411: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_defaultTags
    group_test.go:501: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_defaultTags (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_warning
    group_test.go:583: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_warning (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_disabled
    group_test.go:680: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_disabled (0.00s)
=== RUN   TestAccLogsLogGroup_deletionProtectionEnabled
=== PAUSE TestAccLogsLogGroup_deletionProtectionEnabled
=== CONT  TestAccLogsLogGroup_Identity_Basic
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccLogsLogGroup_kmsKey
=== CONT  TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccLogsLogGroup_tags_null
=== CONT  TestAccLogsLogGroup_namePrefix
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnCreate
=== CONT  TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== CONT  TestAccLogsLogGroup_disappears
=== CONT  TestAccLogsLogGroup_tags_AddOnUpdate
=== CONT  TestAccLogsLogGroup_deletionProtectionEnabled
=== CONT  TestAccLogsLogGroup_logGroupClassDELIVERY2
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccLogsLogGroup_logGroupClassDELIVERY1
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccLogsLogGroup_nameGenerate
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccLogsLogGroup_basic
--- PASS: TestAccLogsLogGroup_logGroupClassDELIVERY2 (45.49s)
=== CONT  TestAccLogsLogGroup_multiple
=== CONT  TestAccLogsLogGroup_skipDestroy
--- PASS: TestAccLogsLogGroup_disappears (50.00s)
--- PASS: TestAccLogsLogGroup_basic (53.24s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccLogsLogGroup_nameGenerate (55.95s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccLogsLogGroup_namePrefix (60.78s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnCreate
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag (67.31s)
=== CONT  TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag (69.39s)
=== CONT  TestAccLogsLogGroup_tags
--- PASS: TestAccLogsLogGroup_skipDestroyInconsistentPlan (84.96s)
=== CONT  TestAccLogsLogGroup_tags_EmptyMap
--- PASS: TestAccLogsLogGroup_deletionProtectionEnabled (92.55s)
=== CONT  TestAccLogsLogGroup_retentionPolicy
--- PASS: TestAccLogsLogGroup_skipDestroy (55.83s)
=== CONT  TestAccLogsLogGroup_Identity_ExistingResource
--- PASS: TestAccLogsLogGroup_tags_null (106.36s)
=== CONT  TestAccLogsLogGroup_logGroupClass
--- PASS: TestAccLogsLogGroup_Identity_Basic (106.52s)
=== CONT  TestAccLogsLogGroup_Identity_RegionOverride
--- PASS: TestAccLogsLogGroup_multiple (61.48s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccLogsLogGroup_tags_AddOnUpdate (122.82s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_overlapping
--- PASS: TestAccLogsLogGroup_logGroupClassDELIVERY1 (122.82s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly (122.82s)
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace (122.99s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnCreate (138.43s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_providerOnly
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnCreate (78.05s)
--- PASS: TestAccLogsLogGroup_logGroupClass (63.48s)
--- PASS: TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag (170.40s)
--- PASS: TestAccLogsLogGroup_kmsKey (173.04s)
--- PASS: TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag (175.30s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag (82.75s)
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add (189.74s)
--- PASS: TestAccLogsLogGroup_tags_EmptyMap (104.79s)
--- PASS: TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange (128.02s)
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add (142.63s)
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace (140.11s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag (73.43s)
--- PASS: TestAccLogsLogGroup_Identity_RegionOverride (91.34s)
--- PASS: TestAccLogsLogGroup_retentionPolicy (118.39s)
--- PASS: TestAccLogsLogGroup_Identity_ExistingResource (105.19s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly (91.18s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping (110.54s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_overlapping (111.33s)
--- PASS: TestAccLogsLogGroup_tags (169.45s)
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_providerOnly (116.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/logs       259.232s

ewbankkit
ewbankkit approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLogsLogGroup_\|TestAccLogsLogGroupDataSource_' PKG=logs ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/logs/... -v -count 1 -parallel 4  -run=TestAccLogsLogGroup_\|TestAccLogsLogGroupDataSource_ -timeout 360m -vet=off
2025/12/03 11:48:30 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/03 11:48:30 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLogsLogGroupDataSource_tags
=== PAUSE TestAccLogsLogGroupDataSource_tags
=== RUN   TestAccLogsLogGroupDataSource_tags_NullMap
=== PAUSE TestAccLogsLogGroupDataSource_tags_NullMap
=== RUN   TestAccLogsLogGroupDataSource_tags_EmptyMap
=== PAUSE TestAccLogsLogGroupDataSource_tags_EmptyMap
=== RUN   TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccLogsLogGroup_Identity_Basic
=== PAUSE TestAccLogsLogGroup_Identity_Basic
=== RUN   TestAccLogsLogGroup_Identity_RegionOverride
=== PAUSE TestAccLogsLogGroup_Identity_RegionOverride
=== RUN   TestAccLogsLogGroup_Identity_ExistingResource
=== PAUSE TestAccLogsLogGroup_Identity_ExistingResource
=== RUN   TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccLogsLogGroup_List_Basic
=== PAUSE TestAccLogsLogGroup_List_Basic
=== RUN   TestAccLogsLogGroup_List_RegionOverride
=== PAUSE TestAccLogsLogGroup_List_RegionOverride
=== RUN   TestAccLogsLogGroup_tags
=== PAUSE TestAccLogsLogGroup_tags
=== RUN   TestAccLogsLogGroup_tags_null
=== PAUSE TestAccLogsLogGroup_tags_null
=== RUN   TestAccLogsLogGroup_tags_EmptyMap
=== PAUSE TestAccLogsLogGroup_tags_EmptyMap
=== RUN   TestAccLogsLogGroup_tags_AddOnUpdate
=== PAUSE TestAccLogsLogGroup_tags_AddOnUpdate
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnCreate
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnCreate
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_providerOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_providerOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_overlapping
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_overlapping
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnCreate
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnCreate
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccLogsLogGroup_basic
=== PAUSE TestAccLogsLogGroup_basic
=== RUN   TestAccLogsLogGroup_nameGenerate
=== PAUSE TestAccLogsLogGroup_nameGenerate
=== RUN   TestAccLogsLogGroup_namePrefix
=== PAUSE TestAccLogsLogGroup_namePrefix
=== RUN   TestAccLogsLogGroup_disappears
=== PAUSE TestAccLogsLogGroup_disappears
=== RUN   TestAccLogsLogGroup_kmsKey
=== PAUSE TestAccLogsLogGroup_kmsKey
=== RUN   TestAccLogsLogGroup_logGroupClass
=== PAUSE TestAccLogsLogGroup_logGroupClass
=== RUN   TestAccLogsLogGroup_retentionPolicy
=== PAUSE TestAccLogsLogGroup_retentionPolicy
=== RUN   TestAccLogsLogGroup_multiple
=== PAUSE TestAccLogsLogGroup_multiple
=== RUN   TestAccLogsLogGroup_skipDestroy
=== PAUSE TestAccLogsLogGroup_skipDestroy
=== RUN   TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== PAUSE TestAccLogsLogGroup_skipDestroyInconsistentPlan
=== RUN   TestAccLogsLogGroup_logGroupClassDELIVERY1
=== PAUSE TestAccLogsLogGroup_logGroupClassDELIVERY1
=== RUN   TestAccLogsLogGroup_logGroupClassDELIVERY2
=== PAUSE TestAccLogsLogGroup_logGroupClassDELIVERY2
=== RUN   TestAccLogsLogGroup_requiredTags
    group_test.go:411: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_defaultTags
    group_test.go:501: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_defaultTags (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_warning
    group_test.go:583: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_warning (0.00s)
=== RUN   TestAccLogsLogGroup_requiredTags_disabled
    group_test.go:680: Environment variable TF_ACC_REQUIRED_TAG_KEY is not set, skipping test
--- SKIP: TestAccLogsLogGroup_requiredTags_disabled (0.00s)
=== RUN   TestAccLogsLogGroup_deletionProtectionEnabled
=== PAUSE TestAccLogsLogGroup_deletionProtectionEnabled
=== CONT  TestAccLogsLogGroupDataSource_tags
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccLogsLogGroup_namePrefix
=== CONT  TestAccLogsLogGroup_skipDestroy
--- PASS: TestAccLogsLogGroup_skipDestroy (11.31s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccLogsLogGroupDataSource_tags (12.21s)
=== CONT  TestAccLogsLogGroup_nameGenerate
--- PASS: TestAccLogsLogGroup_namePrefix (14.45s)
=== CONT  TestAccLogsLogGroup_basic
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_updateToResourceOnly (24.05s)
=== CONT  TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccLogsLogGroup_nameGenerate (13.43s)
=== CONT  TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccLogsLogGroup_basic (13.73s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Add (28.45s)
=== CONT  TestAccLogsLogGroup_logGroupClass
--- PASS: TestAccLogsLogGroup_logGroupClass (10.70s)
=== CONT  TestAccLogsLogGroup_multiple
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnUpdate_Replace (27.76s)
=== CONT  TestAccLogsLogGroup_retentionPolicy
--- PASS: TestAccLogsLogGroup_tags_IgnoreTags_Overlap_DefaultTag (31.72s)
=== CONT  TestAccLogsLogGroup_logGroupClassDELIVERY2
--- PASS: TestAccLogsLogGroup_tags_IgnoreTags_Overlap_ResourceTag (35.87s)
=== CONT  TestAccLogsLogGroup_deletionProtectionEnabled
--- PASS: TestAccLogsLogGroup_multiple (11.15s)
=== CONT  TestAccLogsLogGroup_logGroupClassDELIVERY1
--- PASS: TestAccLogsLogGroup_logGroupClassDELIVERY2 (10.56s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccLogsLogGroup_deletionProtectionEnabled (18.78s)
=== CONT  TestAccLogsLogGroup_tags_ComputedTag_OnCreate
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nullOverlappingResourceTag (15.15s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccLogsLogGroup_retentionPolicy (29.82s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccLogsLogGroup_logGroupClassDELIVERY1 (24.26s)
=== CONT  TestAccLogsLogGroup_kmsKey
--- PASS: TestAccLogsLogGroup_tags_ComputedTag_OnCreate (17.93s)
=== CONT  TestAccLogsLogGroup_skipDestroyInconsistentPlan
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nullNonOverlappingResourceTag (15.21s)
=== CONT  TestAccLogsLogGroup_tags
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_emptyProviderOnlyTag (15.07s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccLogsLogGroup_skipDestroyInconsistentPlan (17.47s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_overlapping
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_updateToProviderOnly (25.51s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping
--- PASS: TestAccLogsLogGroup_kmsKey (42.10s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_providerOnly
--- PASS: TestAccLogsLogGroup_tags (52.72s)
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_overlapping (40.34s)
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_nonOverlapping (40.02s)
=== CONT  TestAccLogsLogGroup_tags_EmptyTag_OnCreate
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Replace (24.22s)
=== CONT  TestAccLogsLogGroup_tags_AddOnUpdate
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_providerOnly (52.43s)
=== CONT  TestAccLogsLogGroup_tags_EmptyMap
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnUpdate_Add (36.66s)
=== CONT  TestAccLogsLogGroup_tags_null
--- PASS: TestAccLogsLogGroup_tags_EmptyTag_OnCreate (26.84s)
=== CONT  TestAccLogsLogGroup_disappears
--- PASS: TestAccLogsLogGroup_tags_AddOnUpdate (23.86s)
=== CONT  TestAccLogsLogGroup_Identity_Basic
--- PASS: TestAccLogsLogGroup_tags_EmptyMap (22.72s)
=== CONT  TestAccLogsLogGroup_List_RegionOverride
    group_list_test.go:92: Terraform CLI version 1.12.2 is below minimum version 1.14.0: skipping test
--- SKIP: TestAccLogsLogGroup_List_RegionOverride (0.07s)
=== CONT  TestAccLogsLogGroup_List_Basic
    group_list_test.go:30: Terraform CLI version 1.12.2 is below minimum version 1.14.0: skipping test
--- SKIP: TestAccLogsLogGroup_List_Basic (0.07s)
=== CONT  TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange
--- PASS: TestAccLogsLogGroup_disappears (11.30s)
=== CONT  TestAccLogsLogGroup_Identity_ExistingResource
--- PASS: TestAccLogsLogGroup_tags_null (24.52s)
=== CONT  TestAccLogsLogGroup_Identity_RegionOverride
--- PASS: TestAccLogsLogGroup_Identity_Basic (23.57s)
=== CONT  TestAccLogsLogGroupDataSource_tags_EmptyMap
--- PASS: TestAccLogsLogGroupDataSource_tags_EmptyMap (12.23s)
=== CONT  TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccLogsLogGroup_Identity_RegionOverride (21.41s)
=== CONT  TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_ResourceTag (13.01s)
=== CONT  TestAccLogsLogGroupDataSource_tags_NullMap
--- PASS: TestAccLogsLogGroup_tags_DefaultTags_emptyResourceTag (16.74s)
=== CONT  TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccLogsLogGroup_Identity_ExistingResource (56.32s)
=== CONT  TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccLogsLogGroupDataSource_tags_NullMap (11.11s)
--- PASS: TestAccLogsLogGroupDataSource_tags_IgnoreTags_Overlap_DefaultTag (11.39s)
--- PASS: TestAccLogsLogGroup_Identity_ExistingResource_NoRefresh_NoChange (61.30s)
--- PASS: TestAccLogsLogGroupDataSource_tags_DefaultTags_nonOverlapping (11.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	277.690s

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 3, 2025
@ewbankkit
Copy link
Contributor

ewbankkit commented Dec 3, 2025

@tabito-hara Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 175eb5f into hashicorp:main Dec 3, 2025
46 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.25.0 milestone Dec 3, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

This functionality has been released in v6.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/logs Issues and PRs that pertain to the logs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.25.0

Development

Successfully merging this pull request may close these issues.

CloudWatch log group deletion protection

2 participants

@tabito-hara @ewbankkit