Skip to content

services/batch util functions: Update to Go 1.22 for-range loop #30994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atombrella wants to merge 1 commit into
base: main
Choose a base branch
from
Open

services/batch util functions: Update to Go 1.22 for-range loop #30994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/services/batch/batch_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ func findBatchPoolContainerRegistryPassword(d *pluginsdk.ResourceData, armServer
func findSensitiveInfoForMountConfig(targetType string, sourceType string, sourceValue string, mountType string, d *pluginsdk.ResourceData) string {
if num, ok := d.GetOk("mount.#"); ok {
n := num.(int)
for i := 0; i < n; i++ {
for i := range n {
if src, ok := d.GetOk(fmt.Sprintf("mount.%d.%v.0.%v", i, mountType, sourceType)); ok && src == sourceValue {
return d.Get(fmt.Sprintf("mount.%d.%v.0.%v", i, mountType, targetType)).(string)
}
Expand Down Expand Up @@ -438,7 +438,7 @@ func flattenBatchPoolUserAccount(d *pluginsdk.ResourceData, account *pool.UserAc

if num, ok := d.GetOk("user_accounts.#"); ok {
n := num.(int)
for i := 0; i < n; i++ {
for i := range n {
if src, nameOk := d.GetOk(fmt.Sprintf("user_accounts.%d.name", i)); nameOk && src == account.Name {
userAccount["password"] = d.Get(fmt.Sprintf("user_accounts.%d.password", i)).(string)
userAccountIndex = i
Expand Down
2 changes: 1 addition & 1 deletion internal/services/batch/batch_pool_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,7 @@ func dataSourceBatchPoolRead(d *pluginsdk.ResourceData, meta interface{}) error
extension["settings_json"] = item.Settings
}

for i := 0; i < n; i++ {
for i := range n {
if v, ok := d.GetOk(fmt.Sprintf("extensions.%d.name", i)); ok && v == item.Name {
extension["protected_settings"] = d.Get(fmt.Sprintf("extensions.%d.protected_settings", i))
break
Expand Down
2 changes: 1 addition & 1 deletion internal/services/batch/batch_pool_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,7 @@ func resourceBatchPoolRead(d *pluginsdk.ResourceData, meta interface{}) error {
extension["settings_json"] = string(settingValue)
}

for i := 0; i < n; i++ {
for i := range n {
if v, ok := d.GetOk(fmt.Sprintf("extensions.%d.name", i)); ok && v == item.Name {
extension["protected_settings"] = d.Get(fmt.Sprintf("extensions.%d.protected_settings", i))
break
Expand Down
Loading