Skip to content

Conversation

@dmitriyrazboev
Copy link
Contributor

No description provided.

@dmitriyrazboev dmitriyrazboev requested review from ihsandemir and removed request for ihsandemir November 7, 2025 11:52
JackPGreen

This comment was marked as outdated.

@JackPGreen JackPGreen self-requested a review November 7, 2025 12:10
Copy link
Contributor

@JackPGreen JackPGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to regenerate the docs - see #1310

@dmitriyrazboev
Copy link
Contributor Author

We need to regenerate the docs - see #1310

I thought we got strip of that part of documentation at all as of https://github.com/hazelcast/hazelcast-cpp-client/pull/1351/files

@JackPGreen
Copy link
Contributor

We need to regenerate the docs - see #1310

I thought we got strip of that part of documentation at all as of https://github.com/hazelcast/hazelcast-cpp-client/pull/1351/files

No - that checks it was done, it doesn't do it for you (annoyingly) unfortunately.

that was my original intention but it's not possible to push from an action in the upstream repo to push to the PR from the fork

ihsandemir
ihsandemir previously approved these changes Nov 7, 2025
@ihsandemir
Copy link
Collaborator

We need to regenerate the docs - see #1310

Actually after we moved the content to the docs web site, the generation and the md.in file is no longer needed. we can remove it totally and remove generation from cmake.

@JackPGreen
Copy link
Contributor

We need to regenerate the docs - see #1310

Actually after we moved the content to the docs web site, the generation and the md.in file is no longer needed. we can remove it totally and remove generation from cmake.

I’m not sure i understand. Could you put up a PR of what we can remove so I can understand, please?

@ihsandemir
Copy link
Collaborator

We need to regenerate the docs - see #1310

Actually after we moved the content to the docs web site, the generation and the md.in file is no longer needed. we can remove it totally and remove generation from cmake.

I’m not sure i understand. Could you put up a PR of what we can remove so I can understand, please?

Here you go #1368

@dmitriyrazboev
Copy link
Contributor Author

We need to regenerate the docs - see #1310

Actually after we moved the content to the docs web site, the generation and the md.in file is no longer needed. we can remove it totally and remove generation from cmake.

I’m not sure i understand. Could you put up a PR of what we can remove so I can understand, please?

Here you go #1368

yes, i had already updated my PR with similar changes ;) thanks

@JackPGreen JackPGreen self-requested a review November 7, 2025 18:08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@dmitriyrazboev dmitriyrazboev merged commit 29a3c1d into hazelcast:master Nov 10, 2025
133 of 136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants