-
Notifications
You must be signed in to change notification settings - Fork 51
Update to new Release cycle 5.6.0 #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JackPGreen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to regenerate the docs - see #1310
I thought we got strip of that part of documentation at all as of https://github.com/hazelcast/hazelcast-cpp-client/pull/1351/files |
No - that checks it was done, it doesn't do it for you (annoyingly) unfortunately. that was my original intention but it's not possible to push from an action in the upstream repo to push to the PR from the fork |
Actually after we moved the content to the docs web site, the generation and the md.in file is no longer needed. we can remove it totally and remove generation from cmake. |
I’m not sure i understand. Could you put up a PR of what we can remove so I can understand, please? |
Here you go #1368 |
yes, i had already updated my PR with similar changes ;) thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬
No description provided.