-
Notifications
You must be signed in to change notification settings - Fork 52
#889 optimise dependencies [API-2338] #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
714c84b
6aac449
4749be2
7ff090d
2206b77
d170b4e
30c2301
ee25396
f64d344
fcf65d7
500ec58
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| // Copyright (c) 2008-2025, Hazelcast, Inc. All Rights Reserved. | ||
| // Copyright (c) 2008-2025, Hazelcast, Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
|
|
@@ -19,7 +19,7 @@ | |
|
|
||
| #pragma warning disable MA0048 // File name must match type name | ||
| #define INTERNAL_NULLABLE_ATTRIBUTES | ||
| #if NETSTANDARD2_0 || NETCOREAPP2_0 || NETCOREAPP2_1 || NETCOREAPP2_2 || NET45 || NET451 || NET452 || NET6 || NET461 || NET462 || NET47 || NET471 || NET472 || NET48 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here and other similar swaps between netstandart2.0 and net framework
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above about these being controlling compilation and the current frameworks. |
||
| #if NETSTANDARD2_0 | ||
|
|
||
| // brings C# 8 nullable attributes to netstandard 2.0 | ||
| // see https://www.meziantou.net/how-to-use-nullable-reference-types-in-dotnet-standard-2-0-and-dotnet-.htm | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| // Copyright (c) 2008-2025, Hazelcast, Inc. All Rights Reserved. | ||
| // Copyright (c) 2008-2025, Hazelcast, Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
|
|
@@ -39,11 +39,7 @@ public MultiAttributeProjection(string[] attributePaths) | |
| { | ||
| if (string.IsNullOrWhiteSpace(attributePath)) | ||
| throw new ArgumentException("No attribute path can be null nor empty.", nameof(attributePaths)); | ||
| #if NETFRAMEWORK | ||
| if (attributePath.Contains("[any]")) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you revert this change since we target
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am looking at it but can you show me where we are targeting framework? |
||
| #else | ||
| if (attributePath.Contains("[any]", StringComparison.OrdinalIgnoreCase)) | ||
| #endif | ||
| throw new ArgumentException("No attribute path can contain the '[any]' operator.", nameof(attributePaths)); | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.