Fix for creation and dropping options of ids temporary tables #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porary.create_tables to false has no effect
…ionFactory.close() PersistentTemporaryTable dropping is obtained setting PersistentTableStrategy.DROP_ID_TABLES to true
DavideD
force-pushed
the
HREACT-69-refactoring
branch
from
f789783 to
c8e4fb4
Compare
The test is for temporary tables created for storing ids
DavideD
force-pushed
the
HREACT-69-refactoring
branch
from
c8e4fb4 to
3f77c6a
Compare
dreab8
approved these changes
Feb 13, 2025
Member
dreab8
left a comment
dreab8
left a comment
There was a problem hiding this comment.
LGTM, thanks for the review and the improvement 👍
Member
Author
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2055
Supersedes #2103
I refactored the test class and removed a leftover