Skip to content

[4.2] Fix insert with stateless session and embedded id #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

[4.2] Fix insert with stateless session and embedded id #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c26887
[#2666] Fix insert with EmbeddedId and stateless session
DavideD Oct 30, 2025
40152ac
[#2666] Test insert with StatelessSession and emebedded id
DavideD Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-core/src/main/java/org/hibernate/reactive/session/impl/ReactiveStatelessSessionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ private CompletionStage<?> generatedIdBeforeInsert(

private CompletionStage<?> generateIdForInsert(Object entity, Generator generator, ReactiveEntityPersister persister) {
if ( generator instanceof ReactiveIdentifierGenerator<?> reactiveGenerator ) {
return reactiveGenerator.generate( (ReactiveConnectionSupplier) this, this )
return reactiveGenerator.generate( (ReactiveConnectionSupplier) this, entity )
.thenApply( id -> castToIdentifierType( id, persister ) );
}

Expand Down
13 changes: 13 additions & 0 deletions hibernate-reactive-core/src/test/java/org/hibernate/reactive/EmbeddedIdTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,19 @@ public void populateDb(VertxTestContext context) {
test( context, getMutinySessionFactory().withTransaction( s -> s.persistAll( pizza, schnitzel ) ) );
}

@Test
public void testStatelessInsert(VertxTestContext context) {
LocationId nottingham = new LocationId( "UK", "Nottingham" );
Delivery mushyPeas = new Delivery( nottingham, "Mushy Peas with mint sauce" );
test( context, getMutinySessionFactory()
.withStatelessTransaction( s -> s.insert( mushyPeas ) )
.chain( () -> getMutinySessionFactory()
.withTransaction( s -> s.find( Delivery.class, nottingham ) )
)
.invoke( result -> assertThat( result ).isEqualTo( mushyPeas ) )
);
}

@Test
public void testFindSingleId(VertxTestContext context) {
test( context, getMutinySessionFactory().withTransaction( s -> s.find( Delivery.class, verbania ) )
Expand Down
Loading