-
Notifications
You must be signed in to change notification settings - Fork 38
Chore/generate xsd #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Chore/generate xsd #1318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we keep the generated config.xsd.
- It's easy to review for external users.
- It's easy to review the change log, diff, blame using git commands.
Also, could we do the same to the protocol adapters to generate tag definition xsd and config xsd?
|
Motivation
Replace the outdated XSD with a generated one.
The added code shows just how problematic the original XSD is.
All methods in GenSchemaMain deal with specialities that were introduced by handcrafting the file.
The handcrafting lead to the use of constructs which aren't supported by JAXB.
So this ensures the file is regenerated on each build and therefore tested together with every test loading an XML config.