Skip to content

Conversation

@codepitbull
Copy link
Contributor

@codepitbull codepitbull commented Dec 1, 2025

Motivation

Replace the outdated XSD with a generated one.

The added code shows just how problematic the original XSD is.
All methods in GenSchemaMain deal with specialities that were introduced by handcrafting the file.
The handcrafting lead to the use of constructs which aren't supported by JAXB.

So this ensures the file is regenerated on each build and therefore tested together with every test loading an XML config.

@cla-bot cla-bot bot added the cla-signed label Dec 1, 2025
Copy link
Member

@caoccao caoccao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we keep the generated config.xsd.

  1. It's easy to review for external users.
  2. It's easy to review the change log, diff, blame using git commands.

Also, could we do the same to the protocol adapters to generate tag definition xsd and config xsd?

@codepitbull
Copy link
Contributor Author

I suggest we keep the generated config.xsd.

  1. It's easy to review for external users.
  2. It's easy to review the change log, diff, blame using git commands.

Also, could we do the same to the protocol adapters to generate tag definition xsd and config xsd?

  1. Good point, will place it in the old place
  2. Yes, that was the next I wanted to go. Right now there is nothing for XML in place in there since we only generate JSON schema for those.

@codepitbull codepitbull added the do not merge Do not merge until this label is removed. label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed do not merge Do not merge until this label is removed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants