[v4] Switch build system to use esbuild #1466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Amazing -- I will be testing this out in the next few days! 😍 |
xenova
requested changes
Dec 3, 2025
Collaborator
xenova
left a comment
xenova
left a comment
There was a problem hiding this comment.
Thanks for the PR! Good start 👍
Comment on lines
21
to
29
| contents: ` | ||
| const noop = () => {}; | ||
| const emptyObj = {}; | ||
| export default emptyObj; | ||
| export const Readable = { fromWeb: noop }; | ||
| export const pipeline = noop; | ||
| export const createWriteStream = noop; | ||
| export const createReadStream = noop; | ||
| ` |
Collaborator
There was a problem hiding this comment.
Will this be added one, or for each module we will ignore? 👀
Comment on lines
18
to
19
| const ORT_JSEP_FILE = 'ort-wasm-simd-threaded.jsep.mjs'; | ||
| const ORT_BUNDLE_FILE = 'ort.bundle.min.mjs'; |
Collaborator
There was a problem hiding this comment.
[WIP] How do we ensure this is bundled with the main library, enabling #1471
| logOverride: { | ||
| "empty-import-meta": "silent", | ||
| }, | ||
| }); |
Collaborator
There was a problem hiding this comment.
same comment as above RE: duplication.
Maybe we can also consolidate dev and build logic to reduce duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.