Update PHPDocs #24
Open
Update PHPDocs #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirkhiz
commented
Dec 24, 2019
amirkhiz
commented
- Add methods PHPDocs
- Add ext-ctype package in composer.json
add new card networks
- Add ext-ctype package in composer.json
ghost
reviewed
Feb 6, 2020
| /build | ||
| /vendor | ||
|
|
||
| /.idea/ |
| "require": { | ||
| "php": ">=5.3.0", | ||
| "lib-pcre": ">=7.3" | ||
| "php": ">=5.6.0", |
There was a problem hiding this comment.
This is a potentially breaking change, should we do this?
+ Update namespace
ghost
suggested changes
Mar 30, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This appears to be formatting and renaming namespace/packages only (to the wrong name). Suggest rejecting PR, however, this repo seems to be unmaintained so not an issue.
| ```json | ||
| "require": { | ||
| "inacho/php-credit-card-validator": "1.*" | ||
| "habil/php-credit-card-validator": "1.*" |
There was a problem hiding this comment.
This should probably stay inacho since it's referring to this repo.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "inacho/php-credit-card-validator", | |||
| "name": "habil/php-credit-card-validator", | |||
| "autoload": { | ||
| "psr-4": { | ||
| "Inacho\\": "src/" | ||
| "Sivax\\": "src/" |
| */ | ||
|
|
||
| namespace Inacho; | ||
| namespace Sivax; |
| /** | ||
| * Class CreditCard | ||
| * @package Inacho | ||
| * @package Sivax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.