-
Notifications
You must be signed in to change notification settings - Fork 0
fix: make block query cutoff properly configurable #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Evalir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, disregard the other review. This should be called BLOCK_QUERY_CUTOFF_BUFFER
prestwich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seconds is not enough resolution. needs to be milliseconds
aa0fb98 to
48769bd
Compare
d6fa407 to
376d078
Compare
cb227d0 to
376d078
Compare
88c0627 to
c7121a6
Compare
Evalir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's better to explicitly circuit break the building process altogether if the deadline ends up being too close to Instant::now() instead of this being implicit, because it indicates we've ran out of time anyway.
| /// current timestamp in UNIX seconds. | ||
| /// An `Instant` representing the simulation deadline as calculated by determining | ||
| /// the milliseconds left in the current slot and adding that to the current | ||
| /// timestamp in UNIX seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're trying to improve resultion, we need to add to the current timestamp in unix milliseconds. using seconds here gives us all the rounding problems we already had
|
converting to draft until the duration math is removed and the bin-base changes are in |
99a5e4a to
aee5c4a
Compare

fix: make block query cutoff properly configurable
At some point in the past, the block query cutoff configuration value was removed and a hard-coded value was added in.
This PR adds the block query cutoff back into the config and uses the config value in the
calculate_deadline function.Builder example environment documentation needs to be updated to reflect this change.