[sycl-post-link] Update spec constant pattern match for Device ASan #20680
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address Sanitizer pass changed the way to get stack offset from PtrIntAdd to GEP instruction. We need to update the patter match corresponding.
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
| using namespace PatternMatch; | ||
| Value *X; | ||
| if (match(V, m_IntToPtr(m_Add(m_PtrToInt(m_Value(X)), m_ConstantInt())))) | ||
| if (match(V, m_GEP(m_Value(X), m_Constant()))) |
Contributor
There was a problem hiding this comment.
Is this the right way to move forward considering that GEP is going to be deprecated upstream in the near future?
Contributor
Author
There was a problem hiding this comment.
Updated it to use m_PtrAdd.
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Nov 20, 2025
Contributor
Author
|
Hi @intel/llvm-gatekeepers, this PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Sanitizer pass changed the way to get stack offset from PtrIntAdd to GEP instruction. We need to update the pattern match rule correspondingly.