Skip to content

Conversation

@hipsterusername
Copy link
Member

Summary

This adds new features to the color picker:

  • Ability to pin the color picker into the top left corner of the canvas.
  • Hex/RGB switch for the color picker
  • Cleaner visibility of the FG/BG toggle.

Related Issues / Discussions

Discord asks.

QA Instructions

Pin it. Unpin it. Hex it. Bop it.

Merge Plan

Merge away.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Sep 19, 2025
@lstein lstein self-requested a review as a code owner November 16, 2025 14:35
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a definite improvement over the current color picker and I'm going to approve it, but here are some ideas for future improvements:

  1. When unpinned, the color picker does not offer a visible foreground/background switch UI element. Users have to know to use the "x" hotkey (this is current color picker behavior as well). The new switch icon should appear in the colorpicker titlebar regardless of whether it is pinned or not.
  2. When unpinning the pinned picker, it simply disappears. It would be more natural for it to return to its unpinned position.
  3. In the unpinned state, the color picker is unmovable. It is pinned to a fixed position in the browser window. It would be more natural for the unpinned picker to be movable by dragging, turning it into a floating window.

@lstein lstein merged commit c6a9847 into main Nov 16, 2025
13 checks passed
@lstein lstein deleted the pickerv2 branch November 16, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants