-
Notifications
You must be signed in to change notification settings - Fork 82
multiline: Specify behavior with respect to formatting. #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tthis is the only way to format the fallback for multiline-unaware clients the same way as for multiline-aware clients
|
lgtm |
|
I'm not sure. This puts a significant burden on clients when interpreting user input and composing a multiline message. |
|
So currently, if someone sends this: then irccloud and the current weechat master will display it like this, because they don't implement this PR: not-bold bold unclear and assuming servers don't do any reformatting, then every client not supporting multiline will get this: so they will display it like this: not-bold bold unclear I understand this can be annoying to implement, but we need to either:
Could we resolve this before weechat ships version 4.0 with draft/multiline support? |
|
Update: weechat released v4.0 without changing its behavior with respect to formatting. |
|
@flashcode As implementer of the multiline spec, could you weigh in on this question? |
|
This has been stalled for some time. I agree that this is the only sensible way of doing it. Any other approach has no sane fallback mechanism. There is however one complication that hasn't been addressed: the current draft says says this about fallback clients:
If the servers don't maintain the lines as sent, this would again lead to different formatting between multiline and non-multiline clients. The only sensible approach to me here seems to be to turn that recommendation into a requirement, i.e. change the 'SHOULD' into a 'MUST'. |
Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
|
Actually, the above would apply not only to fallback clients but also to multiline-capable ones; their representation would also change if the server didn't maintain what the author client sent. |
|
And that's fine. Servers have always been allowed to tamper with the text and color codes if they want to. |
|
I suppose so. Would a recommendation to insert formatting reset codes during such rearrangements (if needed) be reasonable? |
This is the only way to format the fallback for multiline-unaware clients
the same way as for multiline-aware clients