Add tests for unevaluatedItems with minContains = 0 #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is tempting to forgo evaluation of the 'contains' schema when `minContains = 0`. However, when an `unevaluatedItems` schema is present, the `contains` schema must still be evaluated as it will affect the results of the `unevaluatedItems` schema.
gregsdennis
approved these changes
Mar 18, 2025
Contributor
Author
|
@gregsdennis is there anything that needs to be done for this to be merged? |
Member
|
I was waiting for someone else to review, but I don't see a problem with this. |
Member
|
Ah, looks like this indeed hits https://github.com/sourcemeta/blaze. Thanks for reporting it! |
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jul 21, 2025
We incorrectly compile away `contains` when `minContains: 0` even if we do actually need to track evaluation for other reasons (i.e. `unevaluatedItems`). See: json-schema-org/JSON-Schema-Test-Suite#765 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
added a commit
to sourcemeta/blaze
that referenced
this pull request
Jul 21, 2025
We incorrectly compile away `contains` when `minContains: 0` even if we do actually need to track evaluation for other reasons (i.e. `unevaluatedItems`). See: json-schema-org/JSON-Schema-Test-Suite#765 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
syedazeez337
pushed a commit
to syedazeez337/blaze-profiling-lab
that referenced
this pull request
Oct 27, 2025
We incorrectly compile away `contains` when `minContains: 0` even if we do actually need to track evaluation for other reasons (i.e. `unevaluatedItems`). See: json-schema-org/JSON-Schema-Test-Suite#765 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is tempting to forgo evaluation of the 'contains' schema when
minContains = 0. However, when anunevaluatedItemsschema is present, thecontainsschema must still be evaluated as it will affect the results of theunevaluatedItemsschema.It is my understanding that the interaction between
containsandunevaluatedItemsis not defined prior to thedraft2020-12specification, so I have not added the test for any earlier versions.