Skip to content

Conversation

@nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Nov 7, 2025

Adding Arrow button to revert a single block changes in cell like something we have in vs code split view

Screencast.From.2025-11-10.17-48-02.mp4

cc @jtpio @Zsailer @brichet

@nakul-py nakul-py marked this pull request as ready for review November 10, 2025 12:50
@nakul-py nakul-py changed the title WIP: Adding Arrow button to revert a single block changes in cell Adding Arrow button to revert a single block changes in cell Nov 13, 2025
@brichet
Copy link

brichet commented Nov 13, 2025

Thank @nakul-py for working on this, I like it !

I played with it and have some comments:

  • we should probably close the compare widget if all the changes have been reverted. See the image below, there is no more change, but the comparison is still opened.

    Screenshot from 2025-11-13 11-54-07
  • there is an error when trying to revert the changes in the last line of the cell

    Uncaught RangeError: Invalid change range 40 to 57 (in doc of length 56)
    
  • not for this PR, but we should probably display the removed line in the right panel, otherwise it is unclear that the line has been removed (see line 3 below)

    image

@nakul-py
Copy link
Contributor Author

Thanks! @brichet for the deep review. I will look into it soon.

@jtpio jtpio added the enhancement New feature or request label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants