Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,5 @@ cython_debug/
*.log
.logs

node_modules
node_modules
.DS_Store
20 changes: 11 additions & 9 deletions naas_python/domains/space/SpaceDomain.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
ISpaceAdaptor,
Space,
SpaceListResponse,
Container,
)

from typing import List
import json

class SpaceDomain(ISpaceDomain):
def __init__(self, adaptor: ISpaceAdaptor):
Expand All @@ -17,11 +19,13 @@ def add(self):
def create(
self,
name: str,
containers: list,
containers: List[Container],
domain: str,
) -> Space:
) -> Space:
response = self.adaptor.create_space(
name=name, containers=containers, domain=domain
name=name,
containers=containers,
domain=domain
)
return Space(**response)

Expand All @@ -32,11 +36,9 @@ def get(self, name: str):
def delete(self, name: str):
return self.adaptor.delete_space(name=name)

def list(self, page_size: int, page_number: int) -> SpaceListResponse:
response = self.adaptor.list_spaces(
page_size=page_size, page_number=page_number
)
return SpaceListResponse(spaces=response)
def list(self) -> SpaceListResponse:
response = self.adaptor.list_spaces()
return SpaceListResponse(spaces=response)

def update(self, name: str, containers: list, domain: str) -> Space:
response = self.adaptor.update_space(
Expand Down
24 changes: 1 addition & 23 deletions naas_python/domains/space/SpaceSchema.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,29 +68,7 @@ def add(self):


class ISpaceInvoker(metaclass=ABCMeta):
@abstractmethod
def create(self, **kwargs):
raise NotImplementedError

@abstractmethod
def update(self, **kwargs):
raise NotImplementedError

@abstractmethod
def get(self, **kwargs):
raise NotImplementedError

@abstractmethod
def list(self, **kwargs):
raise NotImplementedError

@abstractmethod
def delete(self, **kwargs):
raise NotImplementedError

@abstractmethod
def add(self, **kwargs):
raise NotImplementedError
pass


# Exceptions
Expand Down
Loading