fix #13 : delete snippets

Author: sp-yduck

cloud/services/compute/instance/cloudinit.go

@@ -24,6 +24,30 @@ func reconcileCloudInit(s *Service, vmid int, bootstrap string) error {
 	return nil
 }
 
+// delete CloudConfig
+func (s *Service) deleteCloudConfig() error {
+	storageName := s.scope.GetStorage().Name
+	volumeID := fmt.Sprintf("%s:snippets/%s-user.yml", storageName, s.scope.Name())
+
+	node, err := s.client.Node(s.scope.NodeName())
+	if err != nil {
+		return err
+	}
+	storage, err := node.Storage(storageName)
+	if err != nil {
+		return err
+	}
+	content, err := storage.GetContent(volumeID)
+	if IsNotFound(err) { // return nil if it's already deleted
+		return nil
+	}
+	if err != nil {
+		return err
+	}
+
+	return content.DeleteVolume()
+}
+
 func reconcileCloudInitUser(vmid int, vmName, storageName, bootstrap string, config infrav1.User, ssh scope.SSHClient) error {
 	base := baseUserData(vmName)
 

cloud/services/compute/instance/reconcile.go

@@ -61,6 +61,13 @@ func (s *Service) Delete(ctx context.Context) error {
 	if err := EnsureStoppedOrPaused(*instance); err != nil {
 		return err
 	}
+
+	// delete cloud-config file
+	if err := s.deleteCloudConfig(); err != nil {
+		return err
+	}
+
+	// delete qemu
 	return instance.Delete()
 }
 

go.mod

@@ -7,12 +7,13 @@ require (
 	github.com/onsi/ginkgo/v2 v2.9.2
 	github.com/onsi/gomega v1.27.5
 	github.com/pkg/errors v0.9.1
-	github.com/sp-yduck/proxmox v0.0.0-20230627144956-64b565d07db7
+	github.com/sp-yduck/proxmox v0.0.0-20230702124708-d086ca37fd8f
 	golang.org/x/crypto v0.9.0
 	gopkg.in/yaml.v3 v3.0.1
 	k8s.io/api v0.26.1
 	k8s.io/apimachinery v0.26.1
 	k8s.io/client-go v0.26.1
+	k8s.io/klog/v2 v2.80.1
 	k8s.io/utils v0.0.0-20221128185143-99ec85e7a448
 	sigs.k8s.io/cluster-api v1.4.1
 	sigs.k8s.io/controller-runtime v0.14.5
@@ -72,7 +73,6 @@ require (
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	k8s.io/apiextensions-apiserver v0.26.1 // indirect
 	k8s.io/component-base v0.26.1 // indirect
-	k8s.io/klog/v2 v2.80.1 // indirect
 	k8s.io/kube-openapi v0.0.0-20221012153701-172d655c2280 // indirect
 	sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect

go.sum

@@ -288,8 +288,8 @@ github.com/shopspring/decimal v1.3.1 h1:2Usl1nmF/WZucqkFZhnfFYxxxu8LG21F6nPQBE5g
 github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=
 github.com/sirupsen/logrus v1.4.2/go.mod h1:tLMulIdttU9McNUspp0xgXVQah82FyeX6MwdIuYE2rE=
 github.com/sirupsen/logrus v1.6.0/go.mod h1:7uNnSEd1DgxDLC74fIahvMZmmYsHGZGEOFrfsX/uA88=
-github.com/sp-yduck/proxmox v0.0.0-20230627144956-64b565d07db7 h1:y2VI0xIOh35Dl3vKdbns6TVwe6ReSw4Akyr5qUVyUWU=
-github.com/sp-yduck/proxmox v0.0.0-20230627144956-64b565d07db7/go.mod h1:VIKtGZXlx0nO9Y+K2vJ4z3rJLkZ3v0OvTnKbO22EnL4=
+github.com/sp-yduck/proxmox v0.0.0-20230702124708-d086ca37fd8f h1:n32eSWqWLtjk+jb4B1Ok+W5KoAxuYuouEkXjumqySXI=
+github.com/sp-yduck/proxmox v0.0.0-20230702124708-d086ca37fd8f/go.mod h1:VIKtGZXlx0nO9Y+K2vJ4z3rJLkZ3v0OvTnKbO22EnL4=
 github.com/spaolacci/murmur3 v0.0.0-20180118202830-f09979ecbc72/go.mod h1:JwIasOWyU6f++ZhiEuf87xNszmSA2myDM2Kzu9HwQUA=
 github.com/spf13/cast v1.5.0 h1:rj3WzYc11XZaIZMPKmwP96zkFEnnAmV8s6XbB2aY32w=
 github.com/spf13/pflag v1.0.5 h1:iy+VFUOCP1a+8yFto/drg2CJ5u0yRoB7fZw3DKv/JXA=