Skip to content

Conversation

@Serial-ATA
Copy link
Contributor

@Serial-ATA Serial-ATA commented Nov 25, 2025

I used jsdom for the scraping, but can switch to something else if you have a preferred library. I'm not sure what the best option is.

Unfortunately, there's no:

Also, there are technically URLs for tracks. For example the track for https://ototoy.jp/_/default/p/3016055 is available at https://ototoy.jp/opus/index.php/19511684, but it's just a redirect back to the album page, so I didn't figure it'd be worth adding.

closes #34

@kellnerd kellnerd added feature New feature or request provider Metadata provider labels Nov 26, 2025
@kellnerd
Copy link
Owner

I haven't looked closer yet, but for the DOM parser I had an eye on https://jsr.io/@b-fuze/deno-dom. It is TS/Deno first, almost dependency-free and should be more lightweight, but I haven't used it for anything so far.
Just letting you know in case you are interested to compare or benchmark both, otherwise I would do that eventually and we start with jsdom.

@Serial-ATA
Copy link
Contributor Author

Yeah, I also saw deno-dom in comparison lists. Looks like it'd almost be a drop-in replacement, so I'll try it out tomorrow, probably.

@Serial-ATA
Copy link
Contributor Author

Seems to work fine, only difference is it doesn't have specific element type definitions so some field accesses had to be replaced with getAttribute()

@Serial-ATA Serial-ATA marked this pull request as ready for review November 30, 2025 17:55
@kellnerd kellnerd self-requested a review December 3, 2025 20:07
@kellnerd
Copy link
Owner

kellnerd commented Dec 5, 2025

I'm sorry for the delay, I had really hoped to review the provider this week, but it will probably take me until next week.

@Serial-ATA
Copy link
Contributor Author

All good, take your time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request provider Metadata provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTOTOY

2 participants