-
Notifications
You must be signed in to change notification settings - Fork 19.7k
Support jax2tf in JaxLayer for tf backend #21828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @wenyi-guo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the interoperability of Keras by extending Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for jax2tf within JaxLayer, enabling JAX models to run efficiently with the TensorFlow backend. The changes involve adapting the layer's initialization, random number generation, and the call method to correctly convert JAX functions to TensorFlow graphs. The addition of compute_output_shape_fn provides greater flexibility in defining output shapes. Overall, the implementation appears to be a valuable enhancement for interoperability, with good attention to detailed error messages and integration with existing Keras mechanisms.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21828 +/- ##
==========================================
+ Coverage 82.66% 82.68% +0.02%
==========================================
Files 577 577
Lines 59477 59558 +81
Branches 9329 9349 +20
==========================================
+ Hits 49167 49246 +79
+ Misses 7907 7906 -1
- Partials 2403 2406 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
support jax2tf in JaxLayer for tf backend by convert jax functions to tf.