-
Notifications
You must be signed in to change notification settings - Fork 138
Travel itinerary planner #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xInsanityInRed
wants to merge
23
commits into
king04aman:main
Choose a base branch
from
xInsanityInRed:travel-itinerary-planner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Travel itinerary planner #137
xInsanityInRed
wants to merge
23
commits into
king04aman:main
from
xInsanityInRed:travel-itinerary-planner
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n (file_handler.py).
… function handler (manage_itineraries.py). Also added requirements.txt for pip install.
…w_flight(), AND add_new_attraction) to main.py and manage_itineraries_py, + tidied up itinerary nesting.
… or itinerary attraction) to main.py and manage_itineraries.py + code cleanup.
…nittest manage_itineraries.py file + fixed issues with all itinerary flights showing in "edit an existing itinerary" when only one itinerary's flights should show
…and passed after adding duplication checks in manage_itineraries.py
…ew/editied value from manage_itineraries.py to main.py, then passed this value as a parameter into edit_itinerary() function.
…w_value" parameter.
…_edit_itinerary() unittests.
…n (True/False) where needed for unittesting.
Contributor
|
👋 @xInsanityInRed 👋 We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Checklist
Summary
Created the Travel Itinerary Planner as a CLI application that adds, edits, views, deletes itineraries, and saves these changes to a binary file. Fixes #92
Screenshot
Start screen + Add itinerary
Selecting an itinerary value type to edit/change
Choose to edit something from your own pre-made itineraries (labelled by name)
View your pre-made itineraries in a formatted list
Unittests created to verify the functions work as expected
Live Project Link
Include a link to the live project here.