Skip to content

Make prototype design's Registry.class a Thread-safe Singleton class #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: Apri20
Choose a base branch
from
Open

Make prototype design's Registry.class a Thread-safe Singleton class #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3074e7f
Change: make prototype registry class singleton
Feb 10, 2021
75afa4c
Change: make singleton class thread safe
Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/oops/designPatterns/prototype/PrototypeDemo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
public class PrototypeDemo {

public static void main(String[] args) {
Registry registry = new Registry();
Movie movie = (Movie) registry.createItem("Movie");
Registry registry = Registry.getInstance();
Movie movie = (Movie) registry.createItem("ShortMovie");
movie.setTitle("The Prestige");

System.out.println(movie);
System.out.println(movie.getRuntime());
System.out.println(movie.getTitle());
System.out.println(movie.getUrl());

Movie anotherMovie = (Movie) registry.createItem("Movie");
Movie anotherMovie = (Movie) registry.createItem("ArtMovie");
anotherMovie.setTitle("Gang of Wassepur");

System.out.println(anotherMovie);
Expand Down
23 changes: 22 additions & 1 deletion src/oops/designPatterns/prototype/Registry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,30 @@ public class Registry {

private Map<String, Item> items = new HashMap<String, Item>();

public Registry() {
private static volatile Registry instance;

private static Object mutex = new Object();

private Registry() {
loadItems();
}

public static Registry getInstance() {

Registry result = instance;

if (result == null) {
synchronized (mutex) {
result = instance;
if (result == null) {
instance = result = new Registry();
}
}
}

return result;
}


public Item createItem (String type) {
Item item = null;
Expand Down