Skip to content

Conversation

@yue9944882
Copy link
Member

No description provided.

Signed-off-by: Kubernetes Publisher <k8s-publishing-bot@users.noreply.github.com>
Signed-off-by: Kubernetes Publisher <k8s-publishing-bot@users.noreply.github.com>
Signed-off-by: Kubernetes Publisher <k8s-publishing-bot@users.noreply.github.com>
Signed-off-by: Kubernetes Publisher <k8s-publishing-bot@users.noreply.github.com>
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2025
@brendandburns
Copy link
Contributor

So I was hoping to pick up the recent changes I made to add tlsServerName support to the code generator, but I think I need to up the commit version that we use in the generator, this did pick up some fluent updates, so I think we may as well merge it, but we probably also need to re-squash it or something so tha the CLA bot is happy.

@yue9944882
Copy link
Member Author

just to confirm, does this PR include the tls change you are looking for? note our generation workflow is based on the latest content in this file:

https://github.com/kubernetes-client/gen/blame/master/openapi/java.sh#L52

@brendandburns
Copy link
Contributor

No, we need to wait for an OpenAPI generator release which includes it and then rev the version forward.

We can still merge this though if we want looks like there are some set related fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants