Skip to content

Conversation

@ElijahQuinones
Copy link
Member

What type of PR is this?

/kind cleanup

What is this PR about? / Why do we need it?

This PR fixes up the a1 tests such that they can be run in CI again

How was this change tested?

Ran make e2e/external-a1 on an a1 cluster

Ran 106 of 7450 Specs in 348.622 seconds
SUCCESS! -- 106 Passed | 0 Failed | 0 Pending | 7344 Skipped


Ginkgo ran 1 suite in 5m51.955206757s
Test Suite Passed
+ TEST_PASSED=0
+ set -e
+ set +x

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mdzraf December 1, 2025 19:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign connorjc3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from torredil December 1, 2025 19:46
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2025
@ElijahQuinones ElijahQuinones added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Code Coverage Diff

This PR does not change the code coverage

@ElijahQuinones
Copy link
Member Author

/retest

@ElijahQuinones ElijahQuinones removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2025
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants