-
Notifications
You must be signed in to change notification settings - Fork 597
Add ability to configure node container securityContext #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add ability to configure node container securityContext #1750
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prateekdegaons1991 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @prateekdegaons1991! |
|
Hi @prateekdegaons1991. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9a0f515 to
b430a7f
Compare
Is this a bug fix or adding new feature?
Add ability to pass node container security contexts
What is this PR about? / Why do we need it?
Since modern k8s platforms comes with security webhooks that mutates container securityContexts if they are not passed explicitly.
the existing node daemonSet templates consists hardcoded value for container security
This PR allowes users to pass the container security contexts via the values.yaml file.
What testing is done?
template rendered and could able to see the values being reflected in the rendred template