review fixes

Author: zac-nixon

controllers/gateway/eventhandlers/tcp_route_events.go

@@ -69,16 +69,4 @@ func (h *enqueueRequestsForTCPRouteEvent) enqueueImpactedGateways(ctx context.Co
 			"gateway", gw)
 		queue.Add(reconcile.Request{NamespacedName: gw})
 	}
-
-	gateways, err = gatewayutils.GetImpactedGatewaysFromBackendRefs(ctx, h.k8sClient, route.Spec.Rules, route.Namespace, constants.NLBGatewayController)
-	if err != nil {
-		h.logger.V(1).Info("ignoring unknown gateways referred by", "tcproute", route.Name, "error", err)
-	}
-	for _, gw := range gateways {
-		h.logger.V(1).Info("enqueue gateway for tcproute event",
-			"tcproute", k8s.NamespacedName(route),
-			"gateway", gw)
-		queue.Add(reconcile.Request{NamespacedName: gw})
-	}
-
 }

pkg/deploy/elbv2/frontend_nlb_target_synthesizer.go

@@ -49,6 +49,7 @@ type frontendNlbTargetSynthesizer struct {
 
 // Synthesize processes AWS target groups and deregisters ALB targets based on the desired state.
 func (s *frontendNlbTargetSynthesizer) Synthesize(ctx context.Context) error {
+
 	var resTGs []*elbv2model.TargetGroup
 	s.stack.ListResources(&resTGs)
 	res := s.findSDKTargetGroups()
@@ -109,6 +110,10 @@ func (s *frontendNlbTargetSynthesizer) deregisterCurrentTarget(ctx context.Conte
 }
 
 func (s *frontendNlbTargetSynthesizer) PostSynthesize(ctx context.Context) error {
+	if s.frontendNlbTargetGroupDesiredState == nil {
+		return nil
+	}
+
 	var resTGs []*elbv2model.TargetGroup
 	s.stack.ListResources(&resTGs)
 

pkg/gateway/gatewayutils/gateway_utils.go

@@ -9,7 +9,6 @@ import (
 	"sigs.k8s.io/aws-load-balancer-controller/pkg/gateway/constants"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	gwv1 "sigs.k8s.io/gateway-api/apis/v1"
-	gwalpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2"
 )
 
 // IsGatewayManagedByLBController checks if a Gateway is managed by the ALB/NLB Gateway Controller
@@ -104,48 +103,6 @@ func GetImpactedGatewaysFromParentRefs(ctx context.Context, k8sClient client.Cli
 	return impactedGateways, err
 }
 
-func GetImpactedGatewaysFromBackendRefs(ctx context.Context, k8sClient client.Client, tcpRoutes []gwalpha2.TCPRouteRule, resourceNamespace string, gwController string) ([]types.NamespacedName, error) {
-	resultSet := sets.New[types.NamespacedName]()
-	processedSet := sets.New[types.NamespacedName]()
-	errorSet := sets.New[types.NamespacedName]()
-	for _, route := range tcpRoutes {
-		for _, ref := range route.BackendRefs {
-			if ref.Kind == nil || *ref.Kind != "Gateway" {
-				continue
-			}
-
-			ns := resourceNamespace
-			if ref.Namespace != nil {
-				ns = string(*ref.Namespace)
-			}
-			nsn := types.NamespacedName{
-				Namespace: ns,
-				Name:      string(ref.Name),
-			}
-			if processedSet.Has(nsn) {
-				continue
-			}
-
-			gw := &gwv1.Gateway{}
-			if err := k8sClient.Get(ctx, nsn, gw); err != nil {
-				// Ignore and continue processing other refs
-				errorSet.Insert(nsn)
-				continue
-			}
-			processedSet.Insert(nsn)
-
-			if IsGatewayManagedByLBController(ctx, k8sClient, gw, gwController) {
-				resultSet.Insert(nsn)
-			}
-		}
-	}
-	var err error
-	if resultSet.Len() > 0 {
-		err = fmt.Errorf("failed to list gateways, %s", resultSet.UnsortedList())
-	}
-	return resultSet.UnsortedList(), err
-}
-
 // GetImpactedGatewayClassesFromLbConfig identifies GatewayClasses affected by LoadBalancer configuration changes.
 // Returns GatewayClasses that reference the specified LoadBalancer configuration.
 func GetImpactedGatewayClassesFromLbConfig(ctx context.Context, k8sClient client.Client, lbconfig *elbv2gw.LoadBalancerConfiguration, gwControllers sets.Set[string]) (map[string]*gwv1.GatewayClass, error) {