Skip to content

Helm: Adds istio as a provider-scoped value for the inferencepool Chart #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −6
Open

Helm: Adds istio as a provider-scoped value for the inferencepool Chart #1831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions config/charts/inferencepool/templates/istio.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
{{- if eq .Values.provider.name "istio" }}
{{- /* Prefer .Values.provider.istio, fallback to legacy .Values.istio, then {} */ -}}
{{- $provIstio := (index .Values "provider" "istio") -}}
{{- $legacyIstio := .Values.istio -}}
{{- $istio := coalesce $provIstio $legacyIstio (dict) -}}
{{- $dr := (index $istio "destinationRule") | default (dict) -}}

apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
name: {{ include "gateway-api-inference-extension.name" . }}
spec:
host: {{ .Values.istio.destinationRule.host | default (printf "%s.%s.svc.cluster.local" (include "gateway-api-inference-extension.name" .) .Release.Namespace) }}
host: {{ (index $dr "host") | default (printf "%s.%s.svc.cluster.local" (include "gateway-api-inference-extension.name" .) .Release.Namespace) }}
trafficPolicy:
tls:
mode: SIMPLE
insecureSkipVerify: true
{{- if .Values.istio.destinationRule.trafficPolicy.connectionPool }}
connectionPool:
{{- .Values.istio.destinationRule.trafficPolicy.connectionPool | toYaml | nindent 6 }}
{{- with (index (index $dr "trafficPolicy") "connectionPool") }}
connectionPool:
{{- toYaml . | nindent 6 }}
{{- end }}
{{- end }}
17 changes: 15 additions & 2 deletions config/charts/inferencepool/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,25 @@ provider:
# Set to true if the cluster is an Autopilot cluster.
autopilot: false

# Istio-specific configuration.
# This block is only used if name is "istio".
istio:
destinationRule:
# Provide a way to override the default calculated host
host: ""
# Optional: Enables customization of the traffic policy
trafficPolicy: {}
# connectionPool:
# http:
# maxRequestsPerConnection: 256000

# DEPRECATED and will be removed in v1.3. Instead, use `provider.istio.*`.
istio:
destinationRule:
# Provide a way to override the default calculated host
host: ""
host: ""
# Optional: Enables customization of the traffic policy
trafficPolicy: {}
# connectionPool:
# http:
# maxRequestsPerConnection: 256000
# maxRequestsPerConnection: 256000