-
Notifications
You must be signed in to change notification settings - Fork 191
SLO Aware Routing Plugins and Metrics #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SLO Aware Routing Plugins and Metrics #1839
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BenjaminBraunDev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @BenjaminBraunDev. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
… to be consistent
…te, add predictor check to the beginning of each requestcontrol hook
This PR contains the (now combined) stages 2/3 and 3/3 for adding in the latency prediction functionality to EPP.
New features:
-enable-latency-predictorflag in EPP arg to inform it that sidecars are present and to register slo routing plugins.x-slo-ttft-msandx-slo-tpot-ms) and a boolean for whether to use the SLO routing scheduling profile with slo scoring (x-prediction-based-scheduling). If false, use the default profile and just track and train for future requests.totalRunningRequestsMetricprometheus metric from vLLM, which was removed for being unused in the past, but is now a feature of our latency prediction model.Fixes #1323
Does this PR introduce a user-facing change?: