Skip to content

Conversation

@zirain
Copy link
Contributor

@zirain zirain commented Nov 17, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This existed in v1.3, but missed in v1.4 for v1alpha3.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

fix issue that missing subresources for v1alpha3.BackendTLSPolicy

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2025
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It seems a mistake in #4074, where the +kubebuilder:subresource:status was removed unexpectedly. https://github.com/kubernetes-sigs/gateway-api/pull/4074/files#diff-91c9d9844318bcde549158e45f9cf4adf9bef28a334f1796b95f36f741376bdfL28

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2025
@arkodg
Copy link
Contributor

arkodg commented Nov 17, 2025

cc @shaneutt is it possible to release a v1.4.1 patch release this week with this fix, its blocking upgrade to v1.4 CRDs

@robscott
Copy link
Member

is it possible to release a v1.4.1 patch release this week with this fix, its blocking upgrade to v1.4 CRDs

@arkodg We should discuss the timing of a v1.4.1 release at the community meeting tomorrow, but I generally agree that this should qualify.

/approve
/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link
Contributor

@robscott: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

is it possible to release a v1.4.1 patch release this week with this fix, its blocking upgrade to v1.4 CRDs

@arkodg We should discuss the timing of a v1.4.1 release at the community meeting tomorrow, but I generally agree that this should qualify.

/approve
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, zirain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit f24f3a6 into kubernetes-sigs:main Nov 18, 2025
20 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@robscott: new pull request created: #4245

In response to this:

is it possible to release a v1.4.1 patch release this week with this fix, its blocking upgrade to v1.4 CRDs

@arkodg We should discuss the timing of a v1.4.1 release at the community meeting tomorrow, but I generally agree that this should qualify.

/approve
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants