-
Notifications
You must be signed in to change notification settings - Fork 615
fix: missing subresources for v1alpha3.BackendTLSPolicy #4242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RainbowMango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It seems a mistake in #4074, where the +kubebuilder:subresource:status was removed unexpectedly. https://github.com/kubernetes-sigs/gateway-api/pull/4074/files#diff-91c9d9844318bcde549158e45f9cf4adf9bef28a334f1796b95f36f741376bdfL28
|
cc @shaneutt is it possible to release a v1.4.1 patch release this week with this fix, its blocking upgrade to v1.4 CRDs |
@arkodg We should discuss the timing of a v1.4.1 release at the community meeting tomorrow, but I generally agree that this should qualify. /approve |
|
@robscott: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, zirain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@robscott: new pull request created: #4245 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This existed in v1.3, but missed in v1.4 for v1alpha3.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: