refactor(l1): introduce get_block_headers and bulk fetching in gas_tip_estimator #5438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
considering adding a method that combines both |
MegaRedHand
reviewed
Nov 27, 2025
Collaborator
MegaRedHand
left a comment
MegaRedHand
left a comment
There was a problem hiding this comment.
Can you put the fix in a separate PR?
figtracer
force-pushed
the
refactor_gas_tip_estimator
branch
from
4f6500a to
06aa14c
Compare
Contributor
Author
|
@MegaRedHand for sure! #5444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds a new
get_block_headers(from, to)method to the storage layer for bulk fetching block headers, mirroring the existingget_block_bodies(from, to)method. the gas tip estimator now uses both bulk methods instead of fetching headers and bodies one-by-one.