-
Notifications
You must be signed in to change notification settings - Fork 128
chore(l1): remove AccountStateSlim
#5456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Lines of code reportTotal lines added: Detailed view |
d268150 to
4a80760
Compare
JereSalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the solution you've proposed to this.
I think it would be good to add a comment above the definition of AccountStateSlimCodec talking about why it exists, where it's used and its difference with the AccountState struct. Basically that it's used for sending it to peers without sending the whole hashes when they are "empty hashes", which is what happens most of the times within EOAs (only exceptions within EIP-7702). Also add any other comment that you think worth adding.
Also, has this been tested on snapsync yet? I believe there should be no problems but it would be good to test it there.
Motivation
Description