Skip to content

Conversation

@azteca1998
Copy link
Contributor

@azteca1998 azteca1998 commented Nov 28, 2025

Motivation

Description

@github-actions github-actions bot added the L1 Ethereum client label Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Lines of code report

Total lines added: 86
Total lines removed: 80
Total lines changed: 166

Detailed view
+----------------------------------------------+-------+------+
| File                                         | Lines | Diff |
+----------------------------------------------+-------+------+
| ethrex/crates/common/types/account.rs        | 323   | +86  |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/peer_handler.rs | 1730  | -4   |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/snap.rs    | 335   | -75  |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/snap.rs         | 930   | -1   |
+----------------------------------------------+-------+------+

@azteca1998 azteca1998 force-pushed the remove-account-state-slim branch from d268150 to 4a80760 Compare December 2, 2025 12:55
@azteca1998 azteca1998 marked this pull request as ready for review December 2, 2025 14:01
@azteca1998 azteca1998 requested a review from a team as a code owner December 2, 2025 14:01
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Dec 2, 2025
Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solution you've proposed to this.
I think it would be good to add a comment above the definition of AccountStateSlimCodec talking about why it exists, where it's used and its difference with the AccountState struct. Basically that it's used for sending it to peers without sending the whole hashes when they are "empty hashes", which is what happens most of the times within EOAs (only exceptions within EIP-7702). Also add any other comment that you think worth adding.

Also, has this been tested on snapsync yet? I believe there should be no problems but it would be good to test it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

4 participants