[12.x] Separate workflow for Redis integration tests #57710
+155
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
vadimonus
force-pushed
the
redis-cluster-integration-tests
branch
from
799f65c to
cd50bfb
Compare
vadimonus
changed the title
vadimonus
force-pushed
the
redis-cluster-integration-tests
branch
6 times, most recently
from
0062840 to
3b6df2e
Compare
vadimonus
force-pushed
the
redis-cluster-integration-tests
branch
from
3b6df2e to
8dd375a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently integration tests with redis cluster are available only for queues. So such things as Cache or Broadcasting are not covered. This leads to situation, when new code is not checked to work with well with Redis Cluster.
The problem is revealed later when someone starts using the new functionality in redis-cluster environments, which are mostly some highload or enterprise environments with rare feedback. This leads to issues like #53940 , #56581 , #54522.
One suggestion I have is to move all Redis integration tests into a separate workflow. Here i'm am open to other ideas for organizing tests. Maybe it's better to create separate cache tests workflow.
In this PR redis and redis redis cluster queues tests are moved to separate workflow and united with cache tests. Cache integration tests previously was not executed in such configuration.
This allowed to identify some redis cache features that don't work correctly with Redis Cluster. For now, tests such features are skipped with Redis Cluster, to be uncommented later when compatibility is fixed (in #57714)