Fix VSCode not recognising FormRequest functions

[adzchappers]

VSCode does not recognise some functions in a FormRequest (e.g. $this->has('some-var')), adding /** @mixin \Illuminate\Http\Request */ to the request.stub means that all FormRequests generated from php artisan make:request will have all auto completion and function recognition working correctly in VSCode.

Before

After

[shaedrich]

There must be something wrong with your intelephense setup. As you can clearly see, FormRequest directly extends Request, which makes @mixin superfluous:

framework/src/Illuminate/Foundation/Http/FormRequest.php

Line 15 in a6e9bb5

class FormRequest extends Request implements ValidatesWhenResolved

[adzchappers]

I thought that too, but have seen this now on multiple different computers, both mac and windows based. This resolves it on both.

[shaedrich]

That would mean, you have to put @mixin above every class no matter whether it extends from the very class you mark it to be a mixin of or not.

If it fixes this for you, great. But this is certainly not a bug with the framework. And even if it is, it's not a fix. If anything, it's a workaround.

[adzchappers]

It's only happening on FormRequests which is why i thought it was very strange 🤷🏻

[shaedrich]

Yeah, that might be so, but your supposed fix doesn't get to the bottom of this strangeness. It doesn't fix your problem. You are confusing correlation with causality here. I don't know what VSCode does to pick up the link between the two when you add @mixin but outside of VSCode this change makes zero chance and therefore shouldn't be made part of the framework because—no offense—some people have—and we've all been there—trouble with their IDE.