Skip to content

[druntime-test]: Fix glibc-aarch64 skipped tests #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+81 −18
Open

[druntime-test]: Fix glibc-aarch64 skipped tests #4971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e29d8c3
[druntime-test]: exceptions: Drop musl auto-detection
the-horo Aug 18, 2025
c84b652
[druntime-test]: importc_compare: Drop musl auto-detection
the-horo Aug 18, 2025
d1f74c9
[druntime-test]: memoryerror_stackoverflow.d: Prevent hangs with >=ll…
the-horo Aug 16, 2025
4d2dd8d
[druntime]: Fix posix.sys.shm.shmid_ds on (some) non-x86_64
the-horo Aug 20, 2025
0f40c47
[druntime]: Fix sys.posix.sys.types.nlink_t definition
the-horo Aug 20, 2025
305909f
[druntime-test]: exceptions: Skip memoryerror_null_call on linux-aarch64
the-horo Aug 21, 2025
2f6c206
[druntime-test]: exceptions: Skip spurious memoryerror
the-horo Aug 21, 2025
e5c33a1
[importc]: Fix math.h on glibc aarch64
the-horo Aug 24, 2025
1ae7808
[dmd-testsuite]: compilable/stdcheaders: Reenable math.h on linux aar…
the-horo Aug 24, 2025
85cc74b
[reduce LDC-specific diff wrt. IS_MUSL]
kinke Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/DRuntimeIntegrationTests.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ else()
list(REMOVE_ITEM testnames uuid)
endif()

set(musl "")
set(musl "IS_MUSL=0")
if(TARGET_SYSTEM MATCHES "musl")
set(musl "IS_MUSL=1")
endif()
Expand Down
9 changes: 9 additions & 0 deletions runtime/druntime/test/exceptions/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@ ifdef IN_LDC
include ../../../../dmd/osmodel.mak
endif

ifndef IS_MUSL # LDC defines it externally
ifeq ($(OS),linux)
# FIXME: detect musl libc robustly; just checking Alpine Linux' apk tool for now
ifeq (1,$(shell which apk >/dev/null 2>&1 && echo 1))
IS_MUSL := 1
endif
endif
endif

TESTS=stderr_msg unittest_assert invalid_memory_operation static_dtor \
future_message refcounted rt_trap_exceptions_drt catch_in_finally \
message_with_null
Expand Down
15 changes: 11 additions & 4 deletions runtime/druntime/test/importc_compare/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,19 @@ endif

TESTS := importc_compare

ifndef IS_MUSL # LDC defines it externally
ifeq ($(OS),linux)
# FIXME: detect musl libc robustly; just checking Alpine Linux' apk tool for now
ifeq (1,$(shell which apk >/dev/null 2>&1 && echo 1))
IS_MUSL := 1
endif
endif
endif

# FIXME: fails on Alpine v3.21 with conflicting struct declarations in the C headers:
# /usr/include/asm-generic/fcntl.h(195): Error: struct `importc_includes.flock` conflicts with struct `importc_includes.flock` at /usr/include/fcntl.h(24)
ifeq ($(OS),linux)
ifeq (1,$(IS_MUSL))
TESTS :=
endif
ifeq ($(IS_MUSL),1)
TESTS :=
endif

# FIXME: fails on macOS arm64, e.g., due to unsupported `_Float16`
Expand Down
Loading