build(deps): bump golang.org/x/crypto from 0.35.0 to 0.45.0 in /tools #1175
Conversation
dependabot
bot
added
dependencies
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.35.0 to 0.45.0. - [Commits](golang/crypto@v0.35.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/tools/golang.org/x/crypto-0.45.0
branch
from
dd22b84 to
1430c6b
Compare
|
Trying to figure out why the |
| golang.org/x/tools v0.38.0 // indirect | ||
| golang.org/x/tools/go/expect v0.1.1-deprecated // indirect | ||
| golang.org/x/tools/go/packages/packagestest v0.1.1-deprecated // indirect |
There was a problem hiding this comment.
Ah, I believe it because this golang.org/x/tools bump, bumps the golang.org/x/tools/govet version which now includes a rule to now flag the legacy // +build cases. Will check what our best option is here, or if we should just remove those legacy // +build cases.
With a upgrade to a never version of newer golang.org/x/tools/govet, a lint check to check for legacy buildtag lines starting with `// +build` has been added, as they're no longer needed. In order for the `make lint` check to pass with the newer version, we remove such buildtag lines.
ViktorT-11
added
the
no-changelog
|
@ellemouton, I added an extra commit that removes the legacy Let me know if you agree that removing those legacy buildtag lines is the correct approach to tackle the issue. I noticed that |
ellemouton
deleted the
dependabot/go_modules/tools/golang.org/x/crypto-0.45.0
branch
Bumps golang.org/x/crypto from 0.35.0 to 0.45.0.
Commits
4e0068cgo.mod: update golang.org/x dependenciese79546essh: curb GSSAPI DoS risk by limiting number of specified OIDsf91f7a7ssh/agent: prevent panic on malformed constraint2df4153acme/autocert: let automatic renewal work with short lifetime certsbcf6a84acme: pass context to requestb4f2b62ssh: fix error message on unsupported cipher79ec3a5ssh: allow to bind to a hostname in remote forwarding122a78fgo.mod: update golang.org/x dependenciesc0531f9all: eliminate vet diagnostics0997000all: fix some commentsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.