pkg/driver: Add Driver.AdditionalSetupForSSH()
#4251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norio-nomura
force-pushed
the
add-dirver-additional-setup-for-ssh
branch
from
e57439b to
eafd6fe
Compare
AkihiroSuda
previously approved these changes
Oct 29, 2025
norio-nomura
force-pushed
the
add-dirver-additional-setup-for-ssh
branch
from
eafd6fe to
fd67200
Compare
## pkg/driver: Add `Driver.AdditionalSetupForSSH()` AdditionalSetupForSSH provides additional setup required for SSH connection. It is called after the VM is started, before the first SSH connection. It returns an error if the setup fails. ## pkg/driver/vz: Change waiting `waitSSHLocalPortAccessible` in `Driver.AdditionalSetupForSSH()` instead of `startVM`. `waitSSHLocalPortAccessible` is being used for waiting configuration SSH over VSOCK. It makes `LimaVzDriver.Start()` to return as soon as possible. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
force-pushed
the
add-dirver-additional-setup-for-ssh
branch
from
fd67200 to
2623275
Compare
Contributor
Author
|
Thanks! 🙏🏻 |
Member
|
This breaks the API, so we will need another beta release with this new method... AdditionalSetupForSSH(ctx context.Context) error
Maybe there is also time to fix the // func getWslStatus(ctx context.Context, instName string) (string, error)
InspectStatus(ctx context.Context, inst *limatype.Instance) string
// func getSSHAddress(ctx context.Context, instName string) (string, error)
SSHAddress(ctx context.Context) (string, error)Instead of now, where InspectStatus has side-effects and SSHAddress is a no-op. I will try to make a PR for it, and check it with the WSL2 (and AC and DC) drivers... EDIT: #4270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/driver: Add
Driver.AdditionalSetupForSSH()AdditionalSetupForSSHprovides additional setup required for SSH connection.It is called after the VM is started, before the first SSH connection.
It returns an error if the setup fails.
pkg/driver/vz: Change waiting
waitSSHLocalPortAccessibleinDriver.AdditionalSetupForSSH()instead ofstartVM.waitSSHLocalPortAccessibleis being used for waiting configuration SSH over VSOCK.It makes
LimaVzDriver.Start()to return as soon as possible.Replaces #4248