Skip to content

[HLSL] Implement ddx/ddy_coarse intrinsics #164831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 18, 2025
Merged

[HLSL] Implement ddx/ddy_coarse intrinsics #164831

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
658a184
[HLSL] Implement ddx/ddy_coarse intrinsics
Oct 23, 2025
236c7f7
Revert unneeded SPIR-V target changes
Oct 23, 2025
9fdda35
Change hlsl ddx/y_coarse intrinsic to alias
Oct 23, 2025
0890e4d
Update ddx/y_coarse tests
Oct 23, 2025
3c1060c
[SPIRV] Don't add FP Encoding to OpTypeFloat by default
Oct 25, 2025
afb4ad4
Wrap OpDPdx/yCoarse with OpFConvert where needed.
Oct 25, 2025
579c83d
[SPIRV] ensure OpDpdx/yCoarse aren't produced in opencl
Nov 7, 2025
2cfaedb
ddx/y_coarse test cleanup
Nov 11, 2025
985e7b2
[SPIRV] Add todo to update instruction check when possible
Nov 11, 2025
0e37b75
Add issue number to TODO
Nov 11, 2025
57af4cd
Add spirv run lines to dd_coarse Sema tests
Nov 17, 2025
5c13759
[SPIRV] Cleanup SPIRVInstructionSelector with new helper
Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3146,6 +3146,8 @@ bool SPIRVInstructionSelector::selectDpdCoarse(Register ResVReg,
const SPIRVType *ResType,
MachineInstr &I,
const unsigned DPdOpCode) const {
// TODO: This should check specifically for Fragment Execution Model, but STI
Copy link
Member

@farzonl farzonl Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically we would put the issue number in the todo so #167562

// doesn't provide that information yet.
if (!STI.isShader()) {
std::string DiagMsg;
raw_string_ostream OS(DiagMsg);
Expand Down
Loading