Skip to content

Conversation

@kevinsala
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Nov 8, 2025

@llvm/pr-subscribers-offload

Author: Kevin Sala Penades (kevinsala)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/167092.diff

1 Files Affected:

  • (modified) offload/include/omptarget.h (+13-2)
diff --git a/offload/include/omptarget.h b/offload/include/omptarget.h
index 89aa468689eaf..e3b0494b9e124 100644
--- a/offload/include/omptarget.h
+++ b/offload/include/omptarget.h
@@ -104,8 +104,19 @@ enum TargetAllocTy : int32_t {
 };
 
 inline KernelArgsTy CTorDTorKernelArgs = {
-    1,       0, nullptr,   nullptr,   nullptr,   nullptr, nullptr,
-    nullptr, 0, {0, 0, 0}, {1, 0, 0}, {1, 0, 0}, 0};
+    /* Version= */ 1,
+    /* NumArgs= */ 0,
+    /* ArgBasePtrs= */ nullptr,
+    /* ArgPtrs= */ nullptr,
+    /* ArgSizes= */ nullptr,
+    /* ArgTypes= */ nullptr,
+    /* ArgNames= */ nullptr,
+    /* ArgMappers= */ nullptr,
+    /* Tripcount= */ 0,
+    /* Flags= */ {/* NoWait= */ 0, /* IsCUDA= */ 0, /* Unused= */ 0},
+    /* NumTeams= */ {1, 0, 0},
+    /* ThreadLimit= */ {1, 0, 0},
+    /* DynCGroupMem= */ 0};
 
 struct DeviceTy;
 

Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want to refactor this. Liboffload should not be using this interface at all, it should be a libomptarget thing.

@kevinsala
Copy link
Contributor Author

I really want to refactor this. Liboffload should not be using this interface at all, it should be a libomptarget thing.

@jhuber6 Is this struct actually used? This was a follow-up PR for #152831, but I don't see any usage of the struct.

@kevinsala kevinsala closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants