Test coverage for arrays in cbuffers #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds for arrays of various shapes in cbuffers. These currently fail due to layout issues, which are tracked by llvm/llvm-project#147352.
hekota
reviewed
Nov 18, 2025
| Out[1] = w[2].z; | ||
| Out[2] = v[1].q; | ||
| Out[3] = v[2].q; | ||
| } |
Member
There was a problem hiding this comment.
Does accessing the array inside the struct work too with llvm/llvm-project#147352?
Suggested change
| } | |
| Out[4] = v[0].x[1]; | |
| Out[5] = v[2].x[0]; | |
| } |
Collaborator
Author
There was a problem hiding this comment.
It does. I've added the tests to show it.
| @@ -0,0 +1,101 @@ | |||
| #--- source.hlsl | |||
Member
There was a problem hiding this comment.
This is not a cbuffer test. Either the PR description needs to be updated, or this test should be added in a separate change.
Collaborator
Author
There was a problem hiding this comment.
I must have slipped this one in by accident. I'll remove it from this PR and commit it separately later.
inbelic
approved these changes
Nov 18, 2025
Contributor
inbelic
left a comment
inbelic
left a comment
There was a problem hiding this comment.
LGTM. Relevant buffer visualization links for other reviewers:
This removes XFAILs in a few tests, or updates them to point at the appropriate follow up issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds for arrays of various shapes in cbuffers that were failing before llvm/llvm-project#147352 was implemented, and updates XFAILs appropriately for that change.