Skip to content

Conversation

@sannya-singal
Copy link
Collaborator

Setup the sample application for dms postgres as a source and kinesis target.

@sannya-singal sannya-singal self-assigned this Feb 25, 2025
Copy link
Collaborator

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this sample! 🚀 going to make it easier for our users to try it out.

I have a few comments, one regarding the default values for the Kinesis target, as we might want to use default values to fit more our users use-case, and maybe make it parametrizable?

And another regarding the Postgres external database that it seems we do not make use of.

Thanks!

Copy link
Collaborator

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for addressing the comments!
I still have 2 comments regarding the non-default, maybe we could explain a bit more what that means?

And there's still an env var left from the external Postgres server.

Once this is addressed, let's get this in for the release! 🚀

@k-a-il
Copy link
Collaborator

k-a-il commented Feb 26, 2025

Thank you Sannya, great sample!

Copy link
Collaborator

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the comments! 🚀

@k-a-il k-a-il merged commit 09d1b31 into main Feb 26, 2025
1 check passed
@sannya-singal sannya-singal deleted the sample branch February 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants