Skip to content

[ENH] Update error message printed on overlapping cycles to be more verbose #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2024
Merged

[ENH] Update error message printed on overlapping cycles to be more verbose #100

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
555b8bd
[MNT] Update error message printed on overlapping cycles to be more v…
jwlodek Jul 26, 2024
da2514c
Utilize walrus operator
jwlodek Jul 30, 2024
2a858e4
Fix linting error
jwlodek Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cycler/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ def _process_keys(
r_peek: dict[K, V] = next(iter(right)) if right is not None else {}
l_key: set[K] = set(l_peek.keys())
r_key: set[K] = set(r_peek.keys())
if l_key & r_key:
raise ValueError("Can not compose overlapping cycles")
if common_keys := l_key & r_key:
raise ValueError(f"Cannot compose overlapping cycles, duplicate key(s): {common_keys}")

return l_key | r_key


Expand Down