Update node.ts to handle non-string label data #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apollon77
reviewed
Nov 18, 2025
dashboard/src/client/models/node.ts
Outdated
| get nodeLabel(): string { | ||
| const label = this.attributes["0/40/5"]; | ||
| if (!label) return ''; | ||
| if (!label?.includes) return ''; |
Contributor
There was a problem hiding this comment.
Thanks for your contribution. is that suppose to check weather there is a function "includes"?
So the real solution to check for a string is
typeof label === "string"
Author
There was a problem hiding this comment.
yes that would work even better. Best solution would be to find the source of the bad data.. I can update the pull
Author
|
I updated the pull request with the suggested change |
Author
|
It looks like this needs a label. Perhaps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in home-assistant/core#156671 there is a case in which label is not a string but an object:
This then causes an error in the rendering of the dashboard.
Ideally we would figure out where the bad data comes from. But this should fix the symptom.