fix TC_042_1_CS and TC_043_1_CS / local auth list not supported #425
Conversation
…se it uses a deprecated version of `actions/cache: v2` Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
matth-x
left a comment
matth-x
left a comment
There was a problem hiding this comment.
@razvanphp Thanks again for the fixes (and for updating the CI)! Only one question, then this is good to go
|
|
||
| #if MO_ENABLE_LOCAL_AUTH | ||
| if (authorizationService) { | ||
| if (authorizationService && authorizationService->localAuthListEnabled()) { |
There was a problem hiding this comment.
This affects the SupportedFeatureProfiles Configuration key. In my understanding, that key tells the server what the charger is in theory capable of. When the the server disables unused profiles, then the charger would still be able to support them, in theory.
Did this change come out of an OCTT test case?
There was a problem hiding this comment.
Yes, when disabled, the OCTT expects it not to appear in the list anymore (as it is not supported). This avoids having another precompiled firmware just to pass those tests...
BTW, the memory heap calculation misses some ENV variables I think, I can't fix that one. Do you still have access to those servers or should we look into another cloud-native solution? |
2 participants
Should I add unit tests for those? TBH, those are just for the OCTT test cases to pass... so probably not.
fixes #327