Update all browsers data for global_attributes SVG feature #27389
+62
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates and corrects version values for all browsers for the `global_attributes` SVG feature. This replaces a majority of ranges within the SVG global attributes by copying data from the CSS property counterparts.
queengooborg
added
the
data:svg
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
reviewed
Aug 14, 2025
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
I don't think it's right to assume that the SVG attribute is supported when the corresponding CSS property is supported, because in some cases (don't remember which ones) setting the SVG attribute does not have the expected effect.
@Elchi3 Wdyt?
Member
|
I don't know. It is hard to tell. I think Claas is right that this can't be assumed by default. It might be that in many cases it actually is the case, though. We should probably test further or look for additional evidence before making this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects version values for all browsers for the
global_attributesSVG feature. This replaces a majority of ranges within the SVG global attributes by copying data from the CSS property counterparts.